refactor(config): rename embedded SP kubeconfig and namespace env vars

[jenniferubah]

Summary

• Rename AGENT_KUBECONFIG → SP_DEFAULT_KUBECONFIG (shared default for embedded SPs; SP_KUBECONFIG override unchanged)
• Rename per-SP namespace env vars:
  • SP_K8S_NAMESPACE → SP_CONTAINER_NAMESPACE / SP_STORAGE_NAMESPACE
  • KUBERNETES_NAMESPACE → SP_VM_NAMESPACE

Assisted-By: Cursor AI

[qodo-code-review]

PR Summary by Qodo

Rename embedded SP kubeconfig and namespace environment variables

⚙️ Configuration changes 🧪 Tests 🕐 20-40 Minutes

AI Description

• Rename the shared embedded-SP kubeconfig default to SP_DEFAULT_KUBECONFIG.
• Give container, storage, and VM providers distinct namespace environment variables.
• Preserve SP_KUBECONFIG precedence and verify container namespace defaults.

Diagram

graph TD
  Env["SP env vars"] -->|"default kubeconfig"| Agent["Agent config"] --> Shared["Shared merge"]
  Shared --> ACM["ACM config"] & Container["Container config"] & Storage["Storage config"] & VM["VM config"]
  Env -->|"provider namespaces"| Container & Storage & VM

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Transitional legacy aliases

• ➕ Avoids breaking existing deployments immediately
• ➕ Allows staged migration with deprecation warnings
• ➖ Adds temporary precedence rules and test cases
• ➖ Delays removal of ambiguous legacy names

Recommendation: The provider-specific names and dedicated SPConfig are clearer long-term. If existing deployments may still set AGENT_KUBECONFIG, SP_K8S_NAMESPACE, or KUBERNETES_NAMESPACE, add a time-bounded compatibility layer; otherwise the direct rename is the simplest approach.

Files changed (8) +35 / -12

Refactor (1) +1 / -1

config.goSource embedded SP defaults from SPConfig +1/-1

Source embedded SP defaults from SPConfig

• Maps the root configuration's SP.DefaultKubeconfig into shared embedded-provider defaults. Existing SP_KUBECONFIG override behavior remains unchanged.

internal/openshift/shared/config.go

Tests (3) +23 / -5

config_test.goRename ACM kubeconfig precedence test descriptions +2/-2

Rename ACM kubeconfig precedence test descriptions

• Updates test names to identify SP_DEFAULT_KUBECONFIG as the fallback while retaining coverage that SP_KUBECONFIG takes precedence.

internal/openshift/acmcluster/config/config_test.go

config_unit_test.goCover the renamed container namespace setting +19/-1

Cover the renamed container namespace setting

• Updates kubeconfig fallback terminology and environment cleanup. Adds coverage for explicit SP_CONTAINER_NAMESPACE values and the default namespace when it is absent.

internal/openshift/container/config/config_unit_test.go

config_unit_test.goClarify shared kubeconfig precedence tests +2/-2

Clarify shared kubeconfig precedence tests

• Renames shared configuration test cases to reflect SP_DEFAULT_KUBECONFIG fallback and SP_KUBECONFIG override semantics.

internal/openshift/shared/config_unit_test.go

Other (4) +11 / -6

config.goMove the shared kubeconfig default into SP configuration +8/-3

Move the shared kubeconfig default into SP configuration

• Adds SPConfig to the root configuration and loads the shared embedded-provider kubeconfig from SP_DEFAULT_KUBECONFIG. Removes kubeconfig ownership from AgentConfig to clarify that the setting belongs to embedded service providers.

internal/config/config.go

config.goUse a container-specific namespace variable +1/-1

Use a container-specific namespace variable

• Changes container namespace loading from SP_K8S_NAMESPACE to SP_CONTAINER_NAMESPACE while preserving the default namespace value.

internal/openshift/container/config/config.go

config.goUse a VM-specific namespace variable +1/-1

Use a VM-specific namespace variable

• Changes KubeVirt VM namespace loading from KUBERNETES_NAMESPACE to SP_VM_NAMESPACE while retaining the default namespace.

internal/openshift/kubevirtvm/config/config.go

config.goUse a storage-specific namespace variable +1/-1

Use a storage-specific namespace variable

• Changes storage namespace loading from SP_K8S_NAMESPACE to SP_STORAGE_NAMESPACE while preserving the default namespace value.

internal/openshift/storage/config/config.go

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[gciavarrini]

In production the path is SP_DEFAULT_KUBECONFIG → config.Load → FromAgent → shared.Apply when SP_KUBECONFIG is unset.

This test skips that chain and passes Kubeconfig straight into shared.Agent{...}.
it never reads SP_DEFAULT_KUBECONFIG.

So the old name (“uses agent kubeconfig…”) matched what the test does.
After the rename only the title changed. I don't see a value in this change

[jenniferubah]

Updated it to kubeconfig from shared.Agent to be more explicit - 94e1ba5

[gciavarrini]

SP_DEFAULT_KUBECONFIG moved out of AgentConfig, but internal/config/config_test.go has no case for it

[jenniferubah]

Done, added test 94e1ba5

[gciavarrini]

Same small gap as storage. One test for SP_VM_NAMESPACE would mirror the container coverage and guard the KUBERNETES_NAMESPACE rename.

[jenniferubah]

Added tests for both 94e1ba5

[gabriel-farache]

I am just wondering is the new unit test for config are really needed and if those use cases/behaviours are not already tested by IT (or if they should be tested by IT). Especially as only the new SP_* var are tested

[jenniferubah]

I am just wondering is the new unit test for config are really needed and if those use cases/behaviours are not already tested by IT (or if they should be tested by IT). Especially as only the new SP_* var are tested

Some of the new tests in the acm and container config were redundant and already covered in the shared tests. While the kubevirtvm and storage config tests are of low value and not really needed. I could remove them