fix(test): replace removed /providers with /service-types in TC-30

[vkolodny]

Summary

• PR feat(agent): add environment agent support, remove direct SP management #51 removed the /providers API (replaced by agent management). TC-30
  (auth_disabled_test.go) used /providers as a target endpoint — now uses
  /service-types which is still available in the catalog API.

Fixes the catalog-subsystem CI failure blocking all open PRs on main.

Test plan

• make catalog-subsystem-test — 41/41 specs passed locally

Made with Cursor

[qodo-code-review]

PR Summary by Qodo

Fix TC-30 to use the service-types endpoint

🐞 Bug fix 🧪 Tests 🕐 Less than 5 minutes

AI Description

• Replaces removed /providers calls with the supported /service-types catalog endpoint.
• Restores auth-disabled subsystem coverage and unblocks catalog CI.

Diagram

sequenceDiagram
  actor Test as TC-30 Test
  participant API as Catalog API
  participant Auth as Disabled Auth
  participant Handler as Service Types
  Test->>API: GET with garbage headers
  API->>Auth: Process request
  Auth->>Handler: Bypass authentication
  Handler-->>Test: Return 200 JSON

Loading

High-Level Assessment

The endpoint substitution is the optimal minimal fix: it preserves TC-30's authentication-bypass intent while targeting an active catalog route. Reusing /catalog-items was considered but would reduce endpoint diversity without improving coverage.

Files changed (1) +5 / -5

Bug fix (1) +5 / -5

auth_disabled_test.goReplace removed providers endpoint in TC-30 +5/-5

Replace removed providers endpoint in TC-30

• Changes both auth-disabled scenarios that targeted the removed '/providers' route to use '/service-types'. Existing malformed-header and successful-response assertions remain unchanged; header alignment is also normalized by formatting.

test/subsystem/catalog/auth_disabled_test.go

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗