fix: preserve docs lineage hop counts across expansion - #16381
Open
ernestoongaro wants to merge 1 commit into
Open
ernestoongaro wants to merge 1 commit into
ernestoongaro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16379
Problem
Selecting
3+/+6in the inline docs DAG and clicking Expand resets both controls to1+/+1. Closing the expanded view also loses its hop selections. The lens survives because it uses shared state, while each DAG initializes its hop controls locally.Solution
Initialize each DAG's hop controls from the existing lineage store when its root matches the requested resource. This preserves upstream and downstream selections, including
max, across expansion and closing. A different root still starts at1+/+1, including when recentering an already-mounted DAG.Includes browser regression stories, a changie-generated changelog entry, and rebuilt
web/dist/assets so the fix ships in the dbt binary.Validation
3+control and passes with the fix.pnpm build(TypeScript and Vite), built asset reference checks, andgit diff --checkpassed.Checklist