-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[EPIC] Upstream BigQuery driver patches to ADBC Foundry #16396
Copy link
Copy link
Open
Labels
adapter:bigqueryConcerns the BigQuery adapter / SQL dialect.Concerns the BigQuery adapter / SQL dialect.area:adaptersThe adapter framework/layer connecting Fusion to warehouses (dbt-adapter* crates).The adapter framework/layer connecting Fusion to warehouses (dbt-adapter* crates).type:epicA large body of work tracked as an epic spanning multiple issues/PRs.A large body of work tracked as an epic spanning multiple issues/PRs.
Description
Activity
Metadata
Metadata
Assignees
Labels
adapter:bigqueryConcerns the BigQuery adapter / SQL dialect.Concerns the BigQuery adapter / SQL dialect.area:adaptersThe adapter framework/layer connecting Fusion to warehouses (dbt-adapter* crates).The adapter framework/layer connecting Fusion to warehouses (dbt-adapter* crates).type:epicA large body of work tracked as an epic spanning multiple issues/PRs.A large body of work tracked as an epic spanning multiple issues/PRs.
Why
We don't want to drift too much from the upstream because:
Upstreaming may require changing some code, adding validations, fixing
pre-commitand overall cleanup, as their quality standards are generally higher than ours (oops).End goal
By the end of this epic, our fork should contain minimal differences from upstream, except some dbt-specific hacks that we know won't get accepted upstream (those should be minimal).
Tasks
Done
AdbcConnectionGetObjectsadbc-drivers/bigquery#275In-progress
BIGQUERY:typeArrow metadata to BigQuery FieldType adbc-drivers/bigquery#273TODO
(NOTE: The PRs show up as merged, but they're merged in our internal repo. I still have to replicate them against upstream).
CamelCasetosnake_caseupstreamGetTableSchemagot changed fromCamelCasetosnake_caseuse_storage_api_disabled_clientgot renamed todisable_storage_apiadbc.bigquery.sql.,CamelCasestuff), change dbt to use the new keys.Out of scope
These will not get accepted upstream. We should come back to them later after the Metadata API revision in ADBC 1.2 (see the discussion in adbc-drivers/bigquery#279)
These PRs are dbt-specific do not need to be upstreamed:
These PRs are backports of what already exists upstream, and when we rebase we should just delete the backport commits: