Skip to content

Include shared/, docker/, and tasks/ in the built wheel - #147

Merged
wiggzz merged 3 commits into
mainfrom
wtj/di-fix-ade-bench-shared-packaging
May 26, 2026
Merged

wiggzz merged 3 commits into
mainfrom
wtj/di-fix-ade-bench-shared-packaging

Conversation

@wiggzz

@wiggzz wiggzz commented May 21, 2026 •

Copy link
Copy Markdown
Contributor

Why

ade_bench/handlers/trial_handler.py resolves shared/ as Path(files("ade_bench")) / "../shared" — i.e. a sibling of the installed ade_bench package. This works for editable installs (hatchling puts the source root on sys.path, so the source-tree shared/ is reachable) but breaks for any non-editable install — git, wheel, PyPI — because hatchling's auto-discovery only ships the ade_bench package, not the sibling data directories.

Symptom from a non-editable install:

open .../site-packages/shared/defaults/docker-compose-duckdb-dbt.yaml: no such file or directory

Same root cause affects docker/ (referenced by compose build contexts) and tasks/ (consumed by ai-codegen-api's evaluate.py to enumerate task definitions — currently forces a full ade-bench checkout alongside any consumer). Bundling these makes pip install ade-bench self-sufficient — no sibling checkout required.

What

Force-include shared/, docker/, and tasks/ in the wheel alongside ade_bench/. Built wheel size is ~13 MB.

Verified by building the wheel and confirming shared/defaults/docker-compose-duckdb-dbt.yaml, docker/base/*, and tasks/airbnb001/task.yaml are present.

Drafted by Claude Opus 4.7 under the direction of @wiggzz

@wiggzz
wiggzz requested a review from joellabes May 21, 2026 21:29
@wiggzz
wiggzz marked this pull request as ready for review May 22, 2026 01:55
@wiggzz wiggzz changed the title Include shared/ in the built wheel Include shared/, docker/, and tasks/ in the built wheel May 22, 2026
@wiggzz

wiggzz commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

CI failures are pre-existing, will investigate separately.

@wiggzz
wiggzz merged commit 30d4dc6 into main May 26, 2026
2 of 5 checks passed
@wiggzz
wiggzz deleted the wtj/di-fix-ade-bench-shared-packaging branch May 26, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants