Include shared/, docker/, and tasks/ in the built wheel - #147
Merged
Merged
Conversation
wiggzz
marked this pull request as ready for review
May 22, 2026 01:55
joellabes
approved these changes
May 25, 2026
Contributor
Author
|
CI failures are pre-existing, will investigate separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ade_bench/handlers/trial_handler.pyresolvesshared/asPath(files("ade_bench")) / "../shared"— i.e. a sibling of the installedade_benchpackage. This works for editable installs (hatchling puts the source root onsys.path, so the source-treeshared/is reachable) but breaks for any non-editable install — git, wheel, PyPI — because hatchling's auto-discovery only ships theade_benchpackage, not the sibling data directories.Symptom from a non-editable install:
Same root cause affects
docker/(referenced by compose build contexts) andtasks/(consumed by ai-codegen-api'sevaluate.pyto enumerate task definitions — currently forces a fullade-benchcheckout alongside any consumer). Bundling these makespip install ade-benchself-sufficient — no sibling checkout required.What
Force-include
shared/,docker/, andtasks/in the wheel alongsideade_bench/. Built wheel size is ~13 MB.Verified by building the wheel and confirming
shared/defaults/docker-compose-duckdb-dbt.yaml,docker/base/*, andtasks/airbnb001/task.yamlare present.Drafted by Claude Opus 4.7 under the direction of @wiggzz