bugfix/type-value-and-post-review-cleanup#5
Merged
Conversation
ltrim($name, 'PDO_') treats the second argument as a character set, so PDO_PGSQL collapsed to "gsql" (P, D, O, _ all eaten until the G). Replace with substr($name, 4) which trims the literal "PDO_" prefix. Post-review cleanup bundled in: - Statement: use Override; for #[Override] (consistency) - Driver: translate Russian @note comment to English - ErrorInfo: drop dead getMessage(); annotate __toString with #[Override] - phpcs: exempt top-level src/*.php (@api classes) from RequireAbstractOrFinal so consumers can extend the public Driver Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Connection duplicates the fetchRecord/exec bodies from Statement instead of delegating. StatementTest exercises that code only via Transaction, so the Connection copies were not under test. Add seven tests against a real in-memory SQLite PDO (matching the existing test style): - exec() empty-params branch (PDO::exec direct) - exec() with named params (prepare + execute) - exec() param values are bound, not interpolated - fetchRecord() returns FETCH_KEY_PAIR map - fetchRecord() with bound parameter filters rows - fetchRecord() empty result returns [] - exec() repeated calls each prepare/execute cleanly Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.