fix/exception-handling-contract#4
Merged
Merged
Conversation
Console::run() lets uncaught throwables propagate to Symfony's Application::run() (the boundary handler) by design. Add the missing @throws Exception docblock so the contract is explicit and psalm's MissingThrowsDocblock passes. Rewrite the VerifyCommand test that still pinned the removed swallow-and-return-FAILURE behavior: an unexpected throwable now propagates instead of being converted to Command::FAILURE. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Extract the duplicated InitializationException hint branch from Down/Up/Redo/Verify commands into support/MigratorExceptionReporter, so the hint text and condition live in one place. Behavior unchanged (same output, same Command::INVALID). - Move the shared CommandOptions trait into the cmd\presentation\support namespace so the delivery helper is no longer a peer of concrete commands; update use statements in consumers and tests. - Document that the limit>=0 predicate in CommandOptions is boundary transport normalization; the business rule owner is the core non-negative-int contract (core enforces it only via assert(), so the delivery guard must stay to preserve the command contract). - BootstrapTest: assert exception type only, drop brittle expectExceptionMessage substring checks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.