add command/tools test suite passing phpstan level 9#2
Merged
Conversation
Introduce PHPUnit tests for cmd presentation commands and console output tools, with hand-written fakes. All test code is clean under phpstan level 9 (src + tests + example): - FakeConsoleOutput: type iterable<string> messages per Symfony contract - CommandOptionsTest: route nullable capturedOptions through a typed assertNotNull helper - PrettyConsoleOutputTest: non-empty-string action matching the event - TraceConsoleOutputTest: fresh fake per case instead of array reset Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CommandOptions is a trait, so #[CoversClass] reported it as an invalid coverage target and failed the suite under failOnWarning. Switch to #[CoversTrait]. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce PHPUnit tests for cmd presentation commands and console output tools, with hand-written fakes. All test code is clean under phpstan level 9 (src + tests + example):