chore/review-fixes-1#4

Merged

kuaukutsu merged 14 commits into

mainfrom

chore/review-fixes-1

May 27, 2026

Commits on May 27, 2026

review: clarify @api/@internal boundaries, enforce VO invariants, surface subscriber failures

kuaukutsu
and
claude
committed
review: replace string-keyed subscriptions with typed Subscription DTO

kuaukutsu
and
claude
committed
review: mark exception hierarchy as @api; document extension-point and sealed-root roles

kuaukutsu
and
claude
committed
review: tighten callable to Closure in Workflow private methods

kuaukutsu
and
claude
committed
review: document CommandInterface as driver-extension contract with explicit exception policy

kuaukutsu
and
claude
committed
review: tighten FactoryInterface::makeBody return type to non-empty-string

kuaukutsu
and
claude
committed
review: document Event enum -> payload class mapping and clarify EventInterface role

kuaukutsu
and
claude
committed
review: rename joinBasename to joinSuffix; close PSR-12 nit as WONT-FIX

kuaukutsu
and
claude
committed
review: drop unused ActionType::SKIP enum case

kuaukutsu
and
claude
committed
review: close 4 remaining nits (Command query build, line separator, command\Options @api + invariants)

kuaukutsu
and
claude
committed
review: revert §6 VO-invariant throws; restore assert() static-first philosophy

kuaukutsu
and
claude
committed
review: add tests for InputOptions withers, package & filesystem helpers, drop one message-text assertion

kuaukutsu
and
claude
committed
command fix
kuaukutsu
committed
stat analyze fix
kuaukutsu
committed