Conversation
- Create new crypto-loaders crate for non-AlphaVantage crypto data - Move CoinGecko, CoinMarketCap, CoinPaprika, CoinCap, SosoValue providers - Add CryptoSymbolLoader, CryptoMappingService, and details loader - Implement unified CacheHelper with CacheConfig and CacheConfigProvider trait - Refactor price loaders to use CacheRepository instead of direct DB connections - Add standard cache TTL constants and key prefixes - Refactor av-core market types into separate modules
Crypto cache refactor
- Create new crypto-loaders crate for non-AlphaVantage crypto data - Move CoinGecko, CoinMarketCap, CoinPaprika, CoinCap, SosoValue providers - Add CryptoSymbolLoader, CryptoMappingService, and details loader - Implement unified CacheHelper with CacheConfig and CacheConfigProvider trait - Refactor price loaders to use CacheRepository instead of direct DB connections - Add standard cache TTL constants and key prefixes - Refactor av-core market types into separate modules
# Conflicts: # crates/av-database/postgres/scripts/backup_postgres.sh # crates/av-database/postgres/scripts/populate_for_symbol.sh # crates/av-database/postgres/scripts/populate_intraday_from_year.sh
rebase to master
README changes
Removed duplicate/overlapping variants and added structured context:
- Removed: MissingAPIKey, InvalidAPIKey, CoinGeckoEndpoint, InternalServerError, ServiceUnavailable
- Changed RateLimitExceeded(String) → RateLimitExceeded { provider, retry_after_secs } - now preserves retry info
- Changed ApiError(String) → ApiError { provider, message } - now includes source attribution
- Changed InvalidResponse { api_source, .. } → InvalidResponse { provider, .. } - consistent naming (avoided source which conflicts with thiserror)
- Added: ServerError { provider, message }, AccessDenied { provider, message }
2. Error Conversion (av-loaders/src/crypto/mod.rs)
Improved From<CryptoLoaderError> for LoaderError:
- Now preserves retry_after_secs from rate limit errors (defaults to 60 if not provided)
- All variants handled explicitly - removed catch-all _ => arm
- Context preserved in error messages (provider name included)
1. CryptoLoaderError (crypto-loaders/src/error.rs)
fixed async trait warning in CacheRepositoryExt
Loader refactor
Owner
Author
|
Performed in error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.