Repository navigation
feat(regions): timeline playback and period comparison - #502
Conversation
|
CI/review follow-up addressed (commit
A fresh full CI run is validating the current head: 38893099259. The superseded run was cancelled after its failure was diagnosed, not retried without investigation. |
Review — CS-Coordinator PR#502 — head 29cd1a0Verdict: APPROVE with one note. Reviewed against master Checked
Note (expected behaviour, worth documenting for operators)The history endpoint covers 21 days (504 buckets), but the instances we run keep 48 h (staging, meshview.dk) or 168 h (meshview-pve) in memory. On 48 h instances most of the timeline is outside retained history. Period comparison is withheld when the preceding interval is not fully covered, so a 24 h comparison is borderline and a 7 d comparison is never available. The behaviour is correct and conservative. A short line in the UI or docs ("timeline depth depends on |
Summary
Second Regions milestone: timeline playback and adjacent-period comparison. Stacked on #501; review this PR against
codex/regions-time-window-coverageuntil that first milestone is merged./api/regions/historysnapshot with 504 completed UTC-hour buckets. Reuse the existing background relay computation; no per-frame API requests or packet-store scans in the handler.Evidence and limitations
Performance
History publication is deterministic and capped at 5,000 identities, 32 scopes per identity and 250,000 populated bucket cells. Sparse prefix sums are indexed once in the browser; frames read indexed counts rather than rescanning buckets. Markers are keyed and reused.
Local Apple M5 measurements (not runner guarantees):
Verification
CI readiness follow-up
The first CI run exposed an existing race in the two #382 node-table corner fixtures: initial theme refresh can replace the table between locator resolution and style evaluation. A controlled local reproduction confirmed
isConnected=falseand an empty computedoverflow, while the replacement table correctly computedvisible. These fixtures now use the same Home/theme-ready setup as the adjacent tooltip fixtures. All corner/overflow assertions are retained; no production node or theme behavior changed.GitHub CI is dispatched explicitly on the feature branch because the repository's automatic PR workflow only targets
master, while this PR is stacked. Fork guards prevent publishing or deployment.Final validation: full CI run 38893099259 passed on
29cd1a05(all three server shards, all three browser shards, ingestor, libraries, JavaScript/lint, image validation, and both aggregate gates). Final remote-head review has no open findings. Not merged or deployed.