Repository navigation
Deflake TestRoutePatterns410 second boundary - #484
Merged
Merged
Conversation
Seed helpers read time.Now() separately, so the hidden and unknown rows could get firstSeen values a second apart. All seeds now derive from one rpRefTime; adds a regression test that crosses a second boundary. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
Rapport — CS-Minimax PR#484 #483 — head 36ae179Status: Draft PR open; all CI jobs green, no re-runs needed; ready for human review. Requirement: deterministic test, privacy check not weakened
Other checks
CI per jobAll pass: Go Build & Test, Go Ingestor Tests, Go Libraries & CLI, Go Server Tests 1/3, 2/3, 3/3, JavaScript Unit Tests & Lint, Script & Container Unit Checks, Playwright E2E 1/3, 2/3, 3/3, Validate Docker Image, Verify E2E Shards & Coverage, Verify Go Test Assignments, Build & Publish Docker Image. Skipped (by design): Publish Badges & Summary, Release Artifacts, Deploy Staging. Known-flaky #271 did not fail. Remaining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #483
Problem
TestRoutePatterns410_HiddenHopWithTrafficLooksUnknownseeded its fixture from separatetime.Now()calls (seedRoutePatternsDB,rpAddTraffic,rpInsertObserver, ...). When two calls straddled a second boundary, the hidden and unknown detail responses differed only infirstSeen/lastSeen, so the byte-identical comparison failed.Plan / change
cmd/server/subpaths_visibility_410_test.go.rpRefTime(truncated to the second) is the single reference time for every seed helper.TestRoutePatterns410_SeedsShareOneClockseeds, waits across a second boundary, adds traffic, and asserts one distinctfirst_seen.Verification
go test -run TestRoutePatterns410 -count=50 ./cmd/serverpasses.go test ./...incmd/serverandcmd/ingestor,sh test-all.sh,node test-frontend-helpers.jspass.Config/customizer: none. No perf impact (test code only).
🤖 Generated with Claude Code