Skip to content

audit: store lock reads and region/area set resolution vs upstream PRs 2246 and 2247 #597

Closed

Description

@dborup

Audit task. Compare our store with two upstream fixes (Kpa-clawbot/CoreScope pull request numbers 2246 and 2247; literal references, not linked):

  • 2246: read StoreTx state under s.mu in grouped packets and other readers;
  • 2247: resolve region and area sets before taking s.mu.

We have related fixes (#475 races, #495 no SQL under s.mu, #583 SQL out of mutexes). Determine whether any reader still reads StoreTx state without the lock, or resolves region/area sets (possibly SQL) while holding s.mu. Use -race stress tests on every reader. Report the findings, and fix any gaps with regression tests; if there are none, report that with evidence.

Activity

  1. dborup commented on Oct 25, 2026

    @dborup
    OwnerAuthor

    Fixed by #602 (merged as c84f39848304740810c460a11a2bbef2dc4ecc74).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions