You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-ups from the #542 review (Macmini, APPROVE with nits), none blocking:
N1. The LRU eviction order changed from handler candidate order to sorted observation id. Same entries and same hit/miss decisions, but when one request inserts past lruMaxSize (10000) a different subset survives. Pin the intended order with a test, or document it.
N2. Nothing pins that an absent row or a NULL resolved_path must not enter the LRU; dropping the present guard survives the suite.
N3. Removing both sort.Ints calls survives every test, so the chunk determinism they provide is unverified.
N4. Make the longestTx mapping structurally safe with a seen set or map[int][]int. This is defensive only; it is not reachable through ingest today.
N5.lruMu is taken once per id inside a chunk, up to 500 round-trips; take it once per chunk instead.
Activity
dborup commentedon Oct 24, 2026
Fixed by #552 (merged as
5af6129c4ceb72ccf5cc665b81876762b9330c8a).