Skip to content

paths: follow-ups from #542 (LRU order/NULL pinning tests, per-chunk lruMu) #548

Closed

Description

@dborup

Follow-ups from the #542 review (Macmini, APPROVE with nits), none blocking:

  1. N1. The LRU eviction order changed from handler candidate order to sorted observation id. Same entries and same hit/miss decisions, but when one request inserts past lruMaxSize (10000) a different subset survives. Pin the intended order with a test, or document it.
  2. N2. Nothing pins that an absent row or a NULL resolved_path must not enter the LRU; dropping the present guard survives the suite.
  3. N3. Removing both sort.Ints calls survives every test, so the chunk determinism they provide is unverified.
  4. N4. Make the longestTx mapping structurally safe with a seen set or map[int][]int. This is defensive only; it is not reachable through ingest today.
  5. N5. lruMu is taken once per id inside a chunk, up to 500 round-trips; take it once per chunk instead.

Relates to #542.

Activity

  1. dborup commented on Oct 24, 2026

    @dborup
    OwnerAuthor

    Fixed by #552 (merged as 5af6129c4ceb72ccf5cc665b81876762b9330c8a).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions