Repository navigation
dbeaver/pro#11258 Approve connection initialization SQL by default in dbvr - #138
Merged
Merged
Conversation
IvanGorshechnikov
changed the title
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
SolovevAnton
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection initialization confirmation must not interrupt non-interactive dbvr commands. Register a headless UIServiceConnectionInit service that approves initialization SQL by default.
The service uses the shared model API, including the effective connection URL for desktop approval persistence. The CLI bundle has no dependency on org.jkiss.dbeaver.ext.h2. H2-specific parsing and validation stay in the H2 plugin.
Validation: the CLI service compiled against the updated shared API; 49 focused H2/SQLite tests passed for the combined CE change. Earlier H2 2.4.240 smoke checks verified automatic approval for INIT in the URL, connection properties and escaped names, and the CLI service compiled with H2 bundles excluded from its classpath. IntelliJ workspace regenerated. Full dbvr product build not run.
Depends on dbeaver/dbeaver#42612 for the shared UIServiceConnectionInit API. PRO SQLite integration is tracked in https://github.com/dbeaver/dbeaver-ee/pull/4974.
Closes dbeaver/pro#11258.
Closes dbeaver/pro#11259.
AI tools were used to generate and review this change.