Skip to content

fix: rectified proxy location accessor behavior#219

Merged
drodarie merged 3 commits intomainfrom
fix/proxyloc
Feb 21, 2026
Merged

fix: rectified proxy location accessor behavior#219
drodarie merged 3 commits intomainfrom
fix/proxyloc

Conversation

@Helveg
Copy link
Contributor

@Helveg Helveg commented Feb 18, 2026

Describe the work done

Proxy locations had no location accessors. They now return a location accessor that when used warns users that they're not accessing the location they think they might be accessing when they use the 2 public members .section and .mechanisms. The returned section and mechanisms will belong to a "best guess" from among the branches connected to the proxy (which can come from an arbitrarily complex network of downstream proxies and children, and a parent). This proxied location may have different mechanisms than the proxy, so when a KeyError occurs we throw a specialized KeyError that also explains that the mechanism access was proxied.

List which issues this resolves:

closes #214

Tasks

  • Added tests
  • Updated documentation

📚 Documentation preview 📚: https://arborize--219.org.readthedocs.build/en/219/


📚 Documentation preview 📚: https://bsb-neuron--219.org.readthedocs.build/en/219/

@Helveg Helveg requested a review from drodarie February 18, 2026 20:26
@github-actions github-actions bot added the fix label Feb 18, 2026
@Helveg Helveg requested a review from filimarc February 18, 2026 20:26
Copy link
Contributor

@drodarie drodarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to be merged once the mpi4py issue is solved.

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 97.87234% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.78%. Comparing base (0951e81) to head (713bd63).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
libs/arborize/arborize/builders/_neuron.py 97.05% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   78.73%   75.78%   -2.95%     
==========================================
  Files         196       28     -168     
  Lines       18168     1714   -16454     
  Branches     2141      220    -1921     
==========================================
- Hits        14305     1299   -13006     
+ Misses       3308      363    -2945     
+ Partials      555       52     -503     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drodarie drodarie merged commit d714f18 into main Feb 21, 2026
26 checks passed
@drodarie drodarie deleted the fix/proxyloc branch February 21, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arborize neuron_builder misses location accessors for proxied points

2 participants