fix: rectified proxy location accessor behavior#219
Merged
Conversation
drodarie
approved these changes
Feb 19, 2026
Contributor
drodarie
left a comment
There was a problem hiding this comment.
Good to be merged once the mpi4py issue is solved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
- Coverage 78.73% 75.78% -2.95%
==========================================
Files 196 28 -168
Lines 18168 1714 -16454
Branches 2141 220 -1921
==========================================
- Hits 14305 1299 -13006
+ Misses 3308 363 -2945
+ Partials 555 52 -503 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the work done
Proxy locations had no location accessors. They now return a location accessor that when used warns users that they're not accessing the location they think they might be accessing when they use the 2 public members
.sectionand.mechanisms. The returned section and mechanisms will belong to a "best guess" from among the branches connected to the proxy (which can come from an arbitrarily complex network of downstream proxies and children, and a parent). This proxied location may have different mechanisms than the proxy, so when aKeyErroroccurs we throw a specializedKeyErrorthat also explains that the mechanism access was proxied.List which issues this resolves:
closes #214
Tasks
Updated documentation📚 Documentation preview 📚: https://arborize--219.org.readthedocs.build/en/219/
📚 Documentation preview 📚: https://bsb-neuron--219.org.readthedocs.build/en/219/