Open
Conversation
dennispost
requested review from
annsch,
dkolba,
mfranzke and
nmerget
as code owners
nmerget
reviewed
Oct 29, 2024
| @@ -0,0 +1,233 @@ | |||
| // | |||
Collaborator
There was a problem hiding this comment.
We don't have any Licence information in other files. Should we remove it here @dennispost?
nmerget
reviewed
Oct 29, 2024
| import SwiftUI | ||
|
|
||
| protocol DSDimensions { | ||
| var spacingResponsiveRegularTablet3xs: CGFloat { get } |
Collaborator
There was a problem hiding this comment.
Maybe we can reuse this as a shared constant to generate those dimensions instead of hard coding it?
nmerget
reviewed
Oct 29, 2024
|
|
||
| extension DSTypography { | ||
| init(variant: DSTypographyVariant, density: DSDensity, device: DSDeviceType, sizes: [String: CGFloat]) { | ||
| lineHeight3xs = sizes["\\(variant)LineHeight\\(density.rawValue)\\(device.rawValue)3xs", default: 12] |
Collaborator
There was a problem hiding this comment.
We could create a forEach here to iterate over all t-shirt sizes
nmerget
reviewed
Oct 29, 2024
| "3xl", | ||
| ]; | ||
|
|
||
| export const generateStaticSwiftUIFiles = (): string => { |
Collaborator
There was a problem hiding this comment.
Those are all color related, why did you add it to the shared.ts file instead of colors.ts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.