Centered window moves if the focus is changed to another window in column

[cristobaltapia]

Please fill out the following:

• Scroll Version: 1.13-dev

• Description:

  • This is related to Centered window stops being centered after opening a scratch floating window #335. If I have at least two columns, and in one of these columns there are two windows stacked and set the current window to be centered with align center, then when changing the focus to the other window in the column, the whole column moves to a side instead of staying centered.

• Steps to reproduce

  • Open three windows in a workspace
  • Move one of these windows into one of the other columns (e.g. move left nomode)
  • Center the focused window with align center
  • Move to the other window in the same column (e.g. focus up)

I think that the column should remain centered in this case.

[dawsers]

I think you are right, it would be more intuitive if the column stayed centered. However, there is currently no way to tell what type of alignment the user requested (left/right/center etc.). The align command simply modifies the layout according to the request, and there is no memory aside from "some kind of alignment happened". So the system can only check if the new focused container is out of the viewport, and if it is, reset the alignment. So the fix involves more than what intuition suggests. I will have a look at it. Thanks!

In the meantime, if all you care about is centering, there is also the set_mode <center_horiz|nocenter_horiz|center_vert|nocenter_vert> command that drives the centering mode modifiers.

[cristobaltapia]

Oh, I see. It is a bit tricky then.

[dawsers]

This should be fixed in a774a06. Thank you!

[cristobaltapia]

Great! Thanks for the fix :)