Repository navigation
fix(deps): bump rustls 0.23.43 to 0.23.46 (DAW-81) - #3
Conversation
Clears Dependabot alerts #26 (GHSA-c8m5-c952-6cm4), #27 (GHSA-w44r-93j7-qv28) and #28 (GHSA-h2v8-394m-p7vv); first patched version is 0.23.46. Lockfile-only change via cargo update -p rustls; Cargo.toml constraints (reqwest 0.12 rustls-tls) remain compatible.
tdawe1
left a comment
There was a problem hiding this comment.
Review: scdesk#3 — fix(deps): bump rustls 0.23.43 to 0.23.46 (DAW-81)
Verdict
Approve-ready (comment only — no approval recorded). Lockfile-only patch bump, verified end to end. No blocking findings. (Posting as comment per instruction; never approve/merge from review.)
Spec (DAW-81) — pass
Ticket acceptance was: cargo update rustls to the patched version, cargo audit clean for rustls, tests pass, PR open. All met:
- Diff (
origin/main...HEAD) is exactly one hunk inCargo.lock:rustls 0.23.43 → 0.23.46plus checksum (Cargo.lock:3319). NoCargo.tomlchange, which is correct: rustls is transitive via workspacereqwest 0.12withrustls-tls, whose constraint still resolves (cargo tree -p rustls→v0.23.46;cargo metadata --lockedvalid). cargo audit(0.22.2, observed this session): no finding for therustlscrate. Remaining 5 findings are pre-existing and unrelated —quinn-proto ×3,rustls-webpki,webpki-roots— plus unmaintained warnings (instant,proc-macro-error, …). Untouched by this PR, correctly left for DAW-84.cargo test --workspace --exclude scdesk-pulse --exclude scdesk-journal(observed): 57 passed, 0 failed (contracts 3, journal-core 20, pulse-core 22, scid 5, sierra-paths 7). Matches the PR body's claim.gitleaks git . --log-opts=origin/main..HEAD(observed): no leaks found, 1 commit scanned.
Standards — pass (no documented standards to breach)
Repo has no AGENTS.md, CLAUDE.md, CONTRIBUTING.md, or CODING_STANDARDS.md, so there is no documented convention this diff could violate. Smell baseline: a 2-line version+checksum change admits no naming, duplication, envy, clump, obsession, switch, surgery, divergence, generality, chain, middleman, or bequest concern.
Findings
High — none.
Medium — none.
Low — none blocking.
Informational
- Pre-existing audit findings left in place (correct).
quinn-proto 0.11.17(3× RUSTSEC-2026-0343/0338/0340),rustls-webpki 0.103.15(RUSTSEC-2026-0382),webpki-roots 1.0.9(RUSTSEC-2026-0381) still flag after this PR. Out of scope here; tracked as DAW-84 per the PR body. No action in this PR. - No Gengo submit path in this repo.
grep -rni "gengo|submit"finds nothing; this is the scdesk Pulse/Journal workspace andreqwestis used for Yahoo Finance / forex-calendar fetches (crates/pulse-core/src/yahoo.rs,crates/pulse-core/src/calendar.rs). No TLS-verification bypasses (danger_,no_verifier,accept_invalid) anywhere. Nothing on a submit path is touched. - Security (secrets/auth/injection): nothing touched. Single
Cargo.lockhunk; no code, config, auth, or input-handling change. Gitleaks clean. - Missing tests: none required. Lockfile-only change; existing suite (57 tests) passes and covers the crates that consume
reqwest/TLS. No new behavior to test; no fixtures needed beyond what the suite already uses. - Complexity: none added. Two changed lines, no new abstraction or dependency.
Verification evidence (observed this session, fixtures only, no live Gengo)
cargo test --workspace --exclude scdesk-pulse --exclude scdesk-journal: 57 passed, 0 failed.cargo audit: clean forrustls; 5 unrelated pre-existing findings as above.cargo tree -p rustls --depth 0:rustls v0.23.46;cargo metadata --locked: valid.gitleaks git . --log-opts=origin/main..HEAD: no leaks found.
|
automerge review: ✅ approve (Review (Claude) (anthropic/claude-sonnet-5-5), head Lockfile-only bump of rustls from 0.23.43 to 0.23.46. It changes the version and checksum lines in Cargo.lock and nothing else. The new checksum matches the crates.io index entry for 0.23.46, and that version is not yanked. There are no Cargo.toml, source, test, CI, Gengo or customer-data changes. The PR body says the 0.23.46 bump addresses the three Dependabot rustls advisories. The change is easy to revert and has minimal blast radius. The unrelated cargo audit findings (quinn-proto, rustls-webpki, webpki-roots) are untouched and tracked as DAW-84. I did not rerun tests or cargo audit myself. CI is green and the PR body reports 57 tests passing.
|
Summary
Lockfile-only change via
cargo update -p rustls. NoCargo.tomlchange: rustls is transitive viareqwest 0.12(rustls-tls), and its constraint remains compatible. Clears Dependabot alerts #26, #27 and #28.Evidence
After: rustls 0.23.46;
cargo audit(cargo-audit 0.22.2) reports no finding for therustlscrate.cargo test --workspace --exclude scdesk-pulse --exclude scdesk-journal(CI crate-test command): 57 passed, 0 failed.cargo auditstill reports 5 pre-existing, unrelated vulnerabilities (quinn-proto ×3, rustls-webpki, webpki-roots) plus 13 warnings — versions untouched by this PR, filed as DAW-84.gitleaks git . --log-opts=origin/main..HEAD: no leaks found.Merge Danger
Door: two-way
Lockfile-only dependency patch bump; reverting the single Cargo.lock hunk rolls it back.
Blast Radius: minimal
Potential ramification: TLS behaviour of
reqwestclients changes only by the upstream rustls 0.23.44–0.23.46 patch fixes.What Thomas must do
ci.ymlpermissions fix in the primary checkout.