Cherry ultra low profile version of the sweep#94
Open
ThePurox wants to merge 6 commits intodavidphilipbarr:mainfrom
Open
Cherry ultra low profile version of the sweep#94ThePurox wants to merge 6 commits intodavidphilipbarr:mainfrom
ThePurox wants to merge 6 commits intodavidphilipbarr:mainfrom
Conversation
Owner
|
I'm not opposed to merging this in principle, if you'd rather dump it and run, but it would make more sense for us to just link to your swulp from the readme or something like that? |
Collaborator
|
Is it compatible with the sweep firmware and existing cases? |
Author
|
I'm fine with keeping it in here or linking it to a separate repo under my account. It would be nice though if all the sweeps were in the same repo. |
Collaborator
|
@ThePurox please publish your version as a fork and add it to the "Featured Forks" section of our README 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a cherry ultra low profile version of the sweep. The files are currently untested. If you want to wait for me to test the files before merging, that is totally fine with me.