Repository navigation
feat(api): Refuse IPv4 NetworkService VIPs until galactic serves them - #35
Merged
Merged
Conversation
scotwells
previously approved these changes
Oct 15, 2026
privateip
force-pushed
the
feat/refuse-ipv4-vips
branch
from
October 15, 2026 11:55
a7c4e9a to
ad075e0
Compare
galactic's gateway datapath cannot serve an IPv4 VIP yet (datum-cloud/galactic#705), but vipAddresses admitted one, so a service could carry an address that never answers. A second CEL rule on vipAddresses now refuses any address whose family is not IPv6, using the same CEL IP library as the existing isIP rule. An IPv4-mapped IPv6 address is already refused by isIP. Existing objects keep their IPv4 VIPs while vipAddresses is unchanged, because the API server ratchets validation of an unchanged field (Kubernetes 1.30 and later). Any edit to the list must drop the IPv4 entry. An envtest covers both cases against a real API server, and a Chainsaw test covers the refusal in kind. The rule is replaced by per-family limits once galactic serves IPv4 VIPs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR #34 adds rule_admission_envtest_test.go too, so the two would conflict. Also state on the field that ratcheting needs Kubernetes 1.30 or later, and what an older API server does instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
privateip
changed the title
privateip
force-pushed
the
feat/refuse-ipv4-vips
branch
from
October 15, 2026 11:56
ad075e0 to
db2cdec
Compare
scotwells
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The galactic gateway cannot serve an IPv4 load balancer address yet, but the rule API admits one, so a rule can carry an address that never answers.
The API server now refuses any new IPv4 address in a rule's VIP list. A rule that already holds one keeps it while that list is unchanged, because the API server skips re-checking an unchanged field on Kubernetes 1.30 and later, and any edit to the list must drop it.
Per-family limits replace this rule once galactic serves IPv4 VIPs.
Test plan
Related to datum-cloud/galactic#705
🤖 Generated with Claude Code