Repository navigation
refactor!: Drop vpcAttachmentRef from NetworkRule - #31
Merged
Merged
Conversation
A NetworkRule's backends come from backendSelector, which picks any number of VPCAttachments in vpcRef's VPC. A single attachment reference no longer identifies anything about the rule, and no consumer reads it: galactic only copied it into a struct and an error message. Remove the field from NetworkRuleSpec, the CRD, the sample and the e2e test, and add an e2e step that a rule still setting it is rejected as an unknown field. Reword the shared Accepted reason comments, which also serve NetworkEgressPolicy, so they no longer name the field. NetworkEgressPolicy keeps its own vpcAttachmentRef. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ecv
approved these changes
Oct 9, 2026
3 of 4 tasks
privateip
added a commit
to datum-cloud/galactic
that referenced
this pull request
Oct 9, 2026
Point at network main now that datum-cloud/network#31, which drops NetworkRule's vpcAttachmentRef, has merged, rather than at that PR's branch commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A NetworkRule picks its backends with
backendSelector, which can match many VPCAttachments, so its required single-attachmentvpcAttachmentRefno longer identifies anything. No consumer reads it, so this removes it from the API and the CRD.NetworkEgressPolicy keeps its own
vpcAttachmentRef, since an egress policy still applies to one attachment.Breaking changes
A NetworkRule that still sets
vpcAttachmentRefis rejected as an unknown field. Rules already stored lose the field once the new CRD is installed, and nothing reads it.Galactic's containerlab lab and staging channel install these CRDs from main, and galactic's lab NetworkRules still set the field. Merge this right before the galactic pull request that drops it, so lab rules fail to apply only between the two merges. The staging lab's NetworkRule needs the same one-line removal.
Test plan
vpcRef, a selector and a backend port, and novpcAttachmentRef, is acceptedvpcAttachmentRefis rejected as an unknown field (new chainsaw step)🤖 Generated with Claude Code