Skip to content

fix: Name the condition that reports each hostname problem - #665

Merged
vvoytovych merged 2 commits into
mainfrom
docs/537-hostname-conditions
Oct 19, 2026
Merged

vvoytovych merged 2 commits into
mainfrom
docs/537-hostname-conditions

Conversation

@vvoytovych

Copy link
Copy Markdown
Contributor

The HTTPProxy API documentation says two hostname problems are reported in HostnamesVerified, and the controller names neither there. The condition's own True message also says every hostname is "accepted and programmed", while it checks acceptance only.

Problem The documentation said The controller reports it in
A hostname already programmed on another resource HostnamesVerified HostnamesInUse
A hostname whose DNS record is not programmed HostnamesVerified DNSRecordsProgrammed, since #657
A hostname that is not accepted HostnamesVerified, with the reason HostnamesVerified, by name. The reason is in that hostname's own status

The True message now reads "All hostnames have been accepted", and nothing outside the controller reads its text. The CRD and the API reference are regenerated from the corrected documentation.

Test plan

  • The reconcile test checks the True message. It fails on the old text and passes on the new.
  • The repository's generated-files check passes, and the linter reports no issues.

Related to #537

HostnamesVerified covers ownership and acceptance. A hostname held by another resource is reported in HostnamesInUse, and DNS records in DNSRecordsProgrammed. The API documentation said both went to HostnamesVerified.
…rified is True

The condition checks ownership and acceptance. DNS records are reported in DNSRecordsProgrammed, so the True message promised what the condition does not check.
@vvoytovych
vvoytovych requested a review from a team as a code owner October 19, 2026 05:56
@vvoytovych
vvoytovych merged commit be67e94 into main Oct 19, 2026
17 checks passed
@vvoytovych
vvoytovych deleted the docs/537-hostname-conditions branch October 19, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants