Repository navigation
fix: Name the condition that reports each hostname problem - #665
Merged
Merged
Conversation
HostnamesVerified covers ownership and acceptance. A hostname held by another resource is reported in HostnamesInUse, and DNS records in DNSRecordsProgrammed. The API documentation said both went to HostnamesVerified.
…rified is True The condition checks ownership and acceptance. DNS records are reported in DNSRecordsProgrammed, so the True message promised what the condition does not check.
andrewb3000
approved these changes
Oct 19, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTPProxy API documentation says two hostname problems are reported in
HostnamesVerified, and the controller names neither there. The condition's own True message also says every hostname is "accepted and programmed", while it checks acceptance only.HostnamesVerifiedHostnamesInUseHostnamesVerifiedDNSRecordsProgrammed, since #657HostnamesVerified, with the reasonHostnamesVerified, by name. The reason is in that hostname's own statusThe True message now reads "All hostnames have been accepted", and nothing outside the controller reads its text. The CRD and the API reference are regenerated from the corrected documentation.
Test plan
Related to #537