Skip to content

Fix NSO Galactic mode controller name collision - #663

Merged
scotwells merged 1 commit into
mainfrom
codex/galactic-nso-controller-name-fix
Oct 16, 2026
Merged

scotwells merged 1 commit into
mainfrom
codex/galactic-nso-controller-name-fix

Conversation

@scotwells

Copy link
Copy Markdown
Contributor

Summary

  • Give the Galactic NetworkInterface controller a distinct controller-runtime name.
  • Fix NSO cell manager startup with galactic.enabled: true during the staging API-group migration.

Staging evidence

At 2026-10-16 18:03 UTC, a restarted central staging NSO pod exited with controller with name networkinterface already exists. The prior pod remains healthy after rolling back the restart. East was not restarted.

Verification

  • go test ./internal/galactic/controller ./internal/cmd/cell
  • Resume staging rollout after the fixed NSO image publishes; restart NSO one cell at a time and verify status.attachmentRef.apiGroup becomes galactic.datumapis.com.

@scotwells
scotwells requested a review from a team as a code owner October 16, 2026 18:04
@scotwells
scotwells merged commit 7d706fa into main Oct 16, 2026
17 checks passed
@scotwells
scotwells deleted the codex/galactic-nso-controller-name-fix branch October 16, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants