Skip to content

Move Galactic VPC programming into NSO cell manager - #662

Merged
scotwells merged 7 commits into
mainfrom
codex/galactic-api-group-reprogram
Oct 16, 2026
Merged

scotwells merged 7 commits into
mainfrom
codex/galactic-api-group-reprogram

Conversation

@scotwells

@scotwells scotwells commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Move the Galactic VPC, subnet status, and network interface attachment reconcilers into NSO's cell manager. NSO now creates galactic.datumapis.com VPCs and VPCAttachments, writes NADs, and updates the NSO attachment reference.
  • Keep tenant-facing NSO CRDs in networking.datumapis.com. Gate the new reconcilers behind galactic.enabled and require an explicit attachment mode, so an NSO upgrade can precede the old VPC controller shutdown.
  • Generate the cell manager RBAC and config deepcopy; retain the regression test that checks the new attachment group through reconcile, release, and rebind.

Verification

  • make manifests generate passed.
  • go test ./internal/galactic/... ./internal/cmd/cell ./internal/config ./internal/controller ./internal/cmd/manager -count=1 passed (run as focused package invocations).
  • go vet ./internal/galactic/... ./internal/cmd/cell ./internal/config passed.
  • go test ./internal/... -run '^$' compiled all internal packages.

Rollout

Merge the NSO code before enabling galactic.enabled in any cell. Install Galactic CRDs, stop the old VPC cell controller, then enable NSO with the cell's attachment mode. The staging infra PR remains draft pending the identity and object migration and live inventory.

Companion PRs: datum-cloud/galactic#886 and datum-cloud/infra#7107.

@scotwells
scotwells marked this pull request as ready for review October 16, 2026 14:28
@scotwells
scotwells requested a review from a team as a code owner October 16, 2026 14:28
mattdjenkinson
mattdjenkinson previously approved these changes Oct 16, 2026
@scotwells scotwells changed the title Test NSO preservation of Galactic attachment API group Move Galactic VPC programming into NSO cell manager Oct 16, 2026
@scotwells
scotwells requested a review from privateip October 16, 2026 15:28
privateip
privateip previously approved these changes Oct 16, 2026
@scotwells
scotwells merged commit 39a9ca8 into main Oct 16, 2026
15 checks passed
@scotwells
scotwells deleted the codex/galactic-api-group-reprogram branch October 16, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants