Repository navigation
Move Galactic VPC programming into NSO cell manager - #662
Merged
Merged
Conversation
mattdjenkinson
previously approved these changes
Oct 16, 2026
privateip
previously approved these changes
Oct 16, 2026
privateip
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
galactic.datumapis.comVPCs and VPCAttachments, writes NADs, and updates the NSO attachment reference.networking.datumapis.com. Gate the new reconcilers behindgalactic.enabledand require an explicit attachment mode, so an NSO upgrade can precede the old VPC controller shutdown.Verification
make manifests generatepassed.go test ./internal/galactic/... ./internal/cmd/cell ./internal/config ./internal/controller ./internal/cmd/manager -count=1passed (run as focused package invocations).go vet ./internal/galactic/... ./internal/cmd/cell ./internal/configpassed.go test ./internal/... -run '^$'compiled all internal packages.Rollout
Merge the NSO code before enabling
galactic.enabledin any cell. Install Galactic CRDs, stop the old VPC cell controller, then enable NSO with the cell's attachment mode. The staging infra PR remains draft pending the identity and object migration and live inventory.Companion PRs: datum-cloud/galactic#886 and datum-cloud/infra#7107.