Skip to content

feat: Health-check load balancer backends - #629

Merged
scotwells merged 2 commits into
codex/nlb-api-foundationfrom
codex/nlb-health
Oct 23, 2026
Merged

scotwells merged 2 commits into
codex/nlb-api-foundationfrom
codex/nlb-health

Conversation

@scotwells

@scotwells scotwells commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Closed by mistake while restacking; continued in #715.

Related to #611 and datum-cloud/enhancements#884

@scotwells scotwells changed the title feat: Add cell-local load balancer health checks feat: Health-check load balancer backends Oct 23, 2026
@scotwells
scotwells requested review from ecv and kevwilliams October 23, 2026 14:55
@scotwells
scotwells marked this pull request as ready for review October 23, 2026 14:55
@scotwells
scotwells requested a review from a team as a code owner October 23, 2026 14:55

@kevwilliams kevwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff exceeds auto-review threshold (1678 lines). Flagging for human review.

Keep the original interface identity through projection so a serving
location can confirm a backend still belongs to the right VPC before it
sends it traffic. Backends without a verified identity are left out.

Key changes:
- Preserve the source interface UID on projected interfaces
- Exclude route endpoints without a verified source identity
- Document the serving-location contract
Each location checks its load balancer backends with TCP, HTTP or HTTPS
probes, and only backends with a recent successful check are eligible for
traffic, so a failed backend stops receiving new connections on its own.

Key changes:
- Add a cell-local backend health record and probe runner
- Fail closed when a probe fails, is missing or goes stale
- Require a matching attachment UID before probing a backend
- Report that probing is unavailable until a location can reach VPC backends
@scotwells
scotwells force-pushed the codex/nlb-route-reconcile branch from 9b0b72a to ff35564 Compare October 23, 2026 15:40
Base automatically changed from codex/nlb-route-reconcile to codex/nlb-api-foundation October 23, 2026 15:40
@scotwells
scotwells merged commit 9d4436c into codex/nlb-api-foundation Oct 23, 2026
7 of 12 checks passed
@scotwells
scotwells deleted the codex/nlb-health branch October 23, 2026 15:40
@cla-assistant

cla-assistant Bot commented Oct 23, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@scotwells
scotwells restored the codex/nlb-health branch October 23, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants