Repository navigation
Conversation
The image builds against Connect v1.0.0-preview.14-3, while Connect's current release is preview 28. The CONNECT-IP code the gateway uses is the same in both, and the gateway builds and passes its tests against preview 28 with no source change. One behaviour changes, for a gateway configured to forward UDP. From preview 16, the transport sends UDP requests to a Connector in the standard CONNECT-UDP form and expects the Connector to confirm the Capsule Protocol. A Connector older than preview 16 does not, so UDP forwarding to it fails. TCP forwarding is unchanged, and a gateway with no UDP forwards, such as the one Connect deploys, is unaffected. Raise CONNECT_REV to the preview 28 release commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gateway image builds against Connect v1.0.0-preview.14-3, while Connect's current release is preview 28, and the CONNECT-IP code the gateway uses is identical in both.
This raises the pinned Connect revision to the preview 28 release.
A gateway configured to forward UDP now uses the standard CONNECT-UDP form, which Connectors older than preview 16 cannot answer. The gateway Connect deploys forwards no UDP and is unaffected.
Test plan
Related to datum-cloud/enhancements#883 and datum-cloud/enhancements#916