Skip to content

chore: Stop stamping the router image into the gateway bundle - #748

Merged
privateip merged 1 commit into
mainfrom
fix/issue-701
Oct 6, 2026
Merged

privateip merged 1 commit into
mainfrom
fix/issue-701

Conversation

@privateip

@privateip privateip commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The publish workflow still stamps the galactic-router image tag into the gateway's Kustomize base, which has run one container since galactic-router moved to its own DaemonSet.

The stamp matches nothing, so it does no harm, but its comment misdescribes the gateway pod and two architecture docs repeat the claim.

This removes the stamp and its comment, and corrects both docs.

Test plan

  • The gateway base still renders only the galactic-gateway image before publish
  • The published bundle's gateway base still carries the versioned galactic-gateway image

Fixes #701

🤖 Generated with Claude Code

The publish workflow stamped the galactic-router tag into config/galactic-gateway/base, under a comment saying the gateway DaemonSet runs two containers. It has run one since galactic-router moved to its own DaemonSet, so the stamp matched nothing and did nothing.

Remove the stamp and its comment, and drop the gateway and router architecture docs' descriptions of it, including the Known Constraints entry that flagged it.

Fixes #701

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@privateip privateip self-assigned this Oct 6, 2026
@privateip
privateip marked this pull request as ready for review October 6, 2026 13:13
@privateip
privateip requested a review from a team as a code owner October 6, 2026 13:13
@privateip
privateip enabled auto-merge October 6, 2026 13:13
@privateip

Copy link
Copy Markdown
Collaborator Author

pr-adversary: merge. No findings. The removed stamp matched nothing, since the gateway base is single-container with only the galactic-gateway image.

pr-conventions-reviewer: hold (waived by user decision). Title is 61 characters, over 50, but pr-conventions allows 72. Summary names components and test plan item added to body, both waived as non-blocking. Overlap with #745, #747, #738 in ARCHITECTURE-GATEWAY.md resolved: hunks sit at lines 778+, 40, 109 apart from this PR's deletion at line 772, so merge order is not blocking.

No code changes applied; the PR body was already updated as reviewed.

CI: All checks passed (Lint, Build, Unit Tests, Unit Tests (root), E2E Tests, image publish jobs, CLA).

Merge method: merge, enabled via auto-merge. The ruleset requires 1 code-owner approval and last-push approval; auto-merge will wait for human approval before completing.

@privateip
privateip merged commit 7d0c69f into main Oct 6, 2026
14 checks passed
@privateip
privateip deleted the fix/issue-701 branch October 6, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the stale galactic-router image stamp for the gateway from the publish workflow

2 participants