Repository navigation
docs(masque): Define connector contracts - #1124
Merged
Merged
Conversation
privateip
force-pushed
the
fix/issue-972
branch
2 times, most recently
from
October 27, 2026 12:33
0864bc6 to
1dee8e8
Compare
privateip
marked this pull request as ready for review
October 27, 2026 12:57
Contributor
|
Note This change is unlikely to harm production. Documentation, test, or CI-only change; nothing that runs in production is affected. Polylane analysed Did this help? React 👍 or 👎 so the next review is sharper. Previous verdicts (1)
|
Define client authority and retained prefix allocation on the existing Edge provider contract so transport implementations share ownership and expiry rules. Separate per-connector service deadlines from the shared provider instance lease. Map feature requirements and historical findings to acceptance checks, including replacement, revocation and resource budgets. Mark the older proposal as superseded for this implementation. Fixes #972
privateip
force-pushed
the
fix/issue-972
branch
from
October 27, 2026 13:06
1dee8e8 to
3140dbd
Compare
ecv
approved these changes
Oct 27, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
Docs only: no code, manifest or deploy effect. The contract's links resolve and its numbers match docs/edge/provider-contract.md (15.53 s TakeoverWait, 15.5 s gate expiry, 2 s MaxSkew, 1024-route index, prefix-conflict rule), and the old gateway proposal is marked superseded rather than contradicted.
- Nothing unsafe is committed to: no host access, privilege or second route publisher for the provider, credentials are stored as digests only with a 24 h cap, and allocations are tombstoned and never reassigned.
Follow-ups:
- The 31 s revocation bound mixes a 28 s issuer window with node-side
MaxSkewand drift. Worth one worked example, or a test in the acceptance matrix that derives 31 s, so the arithmetic is checkable. - The grant authority is a single new component that every admission and renewal depends on. Its failure mode (existing sessions expire within 31 s, no new admissions) is stated. Its replica count and leader-election story are not.
- Tombstoned /96s are never reassigned and the ledger caps at 256 entries per VPC/cell, so churn can exhaust a VPC. Say who raises the cap or restores space, and what alert fires before exhaustion.
- A source-IP cap of 8 connections per source will constrain clients behind one NAT; it is flagged as a test-deployment policy, so record the production replacement as an open item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MASQUE implementation needs shared decisions for connector identity, address retention and forwarding authority on the Galactic Edge foundation.
Define those contracts, including independent connector deadlines and replacement rules, and map the feature requirements and earlier review findings to acceptance checks.
The design sets qualification targets and follow-on work rather than claiming runtime acceptance.
Test plan
task docs:checklocally)Fixes #972