Skip to content

docs(masque): Define connector contracts - #1124

Merged
privateip merged 1 commit into
mainfrom
fix/issue-972
Oct 27, 2026
Merged

privateip merged 1 commit into
mainfrom
fix/issue-972

Conversation

@privateip

@privateip privateip commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

MASQUE implementation needs shared decisions for connector identity, address retention and forwarding authority on the Galactic Edge foundation.

Define those contracts, including independent connector deadlines and replacement rules, and map the feature requirements and earlier review findings to acceptance checks.

The design sets qualification targets and follow-on work rather than claiming runtime acceptance.

Test plan

  • Documentation links, anchors, tables and address examples pass consistency checks
  • Repository checks pass (CI, and task docs:check locally)
  • Review confirms that the design and acceptance coverage satisfy the connector milestone

Fixes #972

@privateip privateip self-assigned this Oct 26, 2026
@privateip
privateip force-pushed the fix/issue-972 branch 2 times, most recently from 0864bc6 to 1dee8e8 Compare October 27, 2026 12:33
@privateip
privateip marked this pull request as ready for review October 27, 2026 12:57
@privateip
privateip requested a review from a team as a code owner October 27, 2026 12:57
@polylane

polylane Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Note

This change is unlikely to harm production.

Documentation, test, or CI-only change; nothing that runs in production is affected.

View in Polylane Pause assessments

Polylane analysed 3140dbd for production impact. You can ask follow-ups by mentioning @polylane in a comment.

Did this help? React 👍 or 👎 so the next review is sharper.

Previous verdicts (1)
Head Verdict Analysis
1dee8e8 This change is unlikely to harm production

Define client authority and retained prefix allocation on the existing
Edge provider contract so transport implementations share ownership
and expiry rules. Separate per-connector service deadlines from the
shared provider instance lease.

Map feature requirements and historical findings to acceptance checks,
including replacement, revocation and resource budgets. Mark the older
proposal as superseded for this implementation.

Fixes #972

@ecv ecv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

Docs only: no code, manifest or deploy effect. The contract's links resolve and its numbers match docs/edge/provider-contract.md (15.53 s TakeoverWait, 15.5 s gate expiry, 2 s MaxSkew, 1024-route index, prefix-conflict rule), and the old gateway proposal is marked superseded rather than contradicted.

  • Nothing unsafe is committed to: no host access, privilege or second route publisher for the provider, credentials are stored as digests only with a 24 h cap, and allocations are tombstoned and never reassigned.

Follow-ups:

  • The 31 s revocation bound mixes a 28 s issuer window with node-side MaxSkew and drift. Worth one worked example, or a test in the acceptance matrix that derives 31 s, so the arithmetic is checkable.
  • The grant authority is a single new component that every admission and renewal depends on. Its failure mode (existing sessions expire within 31 s, no new admissions) is stated. Its replica count and leader-election story are not.
  • Tombstoned /96s are never reassigned and the ledger caps at 256 entries per VPC/cell, so churn can exhaust a VPC. Say who raises the cap or restores space, and what alert fires before exhaustion.
  • A source-IP cap of 8 connections per source will constrain clients behind one NAT; it is flagged as a test-deployment policy, so record the production replacement as an open item.

@privateip
privateip merged commit 20d8313 into main Oct 27, 2026
23 checks passed
@privateip
privateip deleted the fix/issue-972 branch October 27, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define connector admission, addressing and ownership contracts

2 participants