Repository navigation
fix: Restore the E2E suite broken by the external-dns 1.22 chart - #11
Merged
Merged
Conversation
The e2e setup installs the upstream external-dns chart with an open version range. Chart 1.22.0, released 2026-09-11, made the policy value required, so the chart now fails its own schema check against the e2e values, nothing installs, and every E2E run times out waiting for the HelmRelease before a test runs. Key changes: - Set policy to upsert-only, the value the chart used to default to - Pin the chart to 1.22.0 so a new upstream chart release cannot break CI without a reviewed version bump
ecv
self-requested a review
September 26, 2026 21:59
ecv
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The E2E job has failed on every run since the upstream external-dns chart released 1.22.0 on Sep 11, which made the
policyvalue required.The test setup installs whatever chart version is newest and never set
policy. The chart now rejects those values, nothing gets installed, and setup times out before any test runs.This change sets
policytoupsert-only, the value the chart used to default to, and pins the chart to 1.22.0 so the next upstream release cannot break CI unannounced.Test plan
--policy=upsert-onlyRelated to #10