Repository navigation
fix: Remove a record set's records of other types - #258
Merged
Merged
Conversation
A record set that changed type kept its old records in PowerDNS. The agent pruned only records of the set's current type, so an ALIAS that became a CNAME conflicted with its own old ALIAS, and deleting the set left the old record behind. The agent now deletes every record that the set's ownership note names and that the set no longer wants, whatever its type. A delete at a name the set rewrites travels in the same PATCH, ahead of the rewrite, so a refused rewrite rolls back and the old record keeps serving. A conflict message no longer names the set's own old record. The agent logs and counts each record of another type that it deletes. The record set controller's comment said a resync corrects drift. A resync stops at the same programmed-at-generation check, so it does not, and the comment now says so. Fixes #225
vvoytovych
marked this pull request as ready for review
October 20, 2026 16:41
ecv
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A record set that changes type keeps its old record in PowerDNS. When an ALIAS becomes a CNAME, the old ALIAS blocks the new CNAME, and the record set reports a conflict with itself. Deleting the record set leaves the old record behind.
This removes every record a record set wrote and no longer wants, whatever its type.
Test plan
Fixes #225