Repository navigation
fix: drop the retired location viewer role - #296
Merged
Merged
Conversation
The viewer role inherited the location viewer from two services while both served locations. Only one serves them now: the network services operator deleted its location roles when it adopted the locations service API, so the role named here no longer exists. An inherited role that is absent leaves the role unreconciled, and every assignable organization role fails its health check behind it. That reads as missing access rather than a failure, which is why it is worth removing rather than leaving to rot. Nothing is lost. The locations service role granting the same read was already listed alongside it. The location binding viewer on the owner role stays. That type is deprecated but still served, and still written by the service catalog.
kevwilliams
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organization viewer role inherited the location viewer from two services while both of them served locations. Only one does now — the network services operator deleted its location roles when it adopted the locations service API — so the role named here refers to something that no longer exists. This removes it.
An inherited role that is absent leaves the inheriting role unreconciled, and every assignable organization role fails its health check behind it. On staging that is happening already: viewer, editor and owner have all been stuck since the operator build rolled out, and several policy bindings referencing the same retired roles broke in the same minute. The failure presents as missing access rather than as a crash, which is why it is worth removing rather than leaving to decay.
Nothing is lost by the removal. The locations service role granting the same read was already listed beside it, which is exactly what the comment there anticipated: both were listed only while both groups were served.
The location binding viewer on the owner role deliberately stays. That type is deprecated but still served, and still written by the service catalog, so its role is still real.
Timing
Production takes the operator change on its next release, and these roles disappear there at that moment. This should land with that release rather than after it, or production repeats what staging is doing now.
Test plan