Repository navigation
revert(quota): drop per-user note quota grant - #295
Merged
Merged
Conversation
Reverts #291. The milo side that would have consumed this was dropped: notes on contacts are only ever created by platform users, so there is nothing to meter and the resource type it grants no longer exists. Left as-is this mints a ResourceGrant per user for a resource type nothing claims, growing with every new user. The project-scoped notes grant is untouched and still does real work.
yahyafakhroji
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #291.
Why
#291 granted every user an allowance for
notes.miloapis.com/user-notes, to meter notes on contacts against their author. The milo side that defined and claimed that resource type (milo-os/milo#793) has been closed — notes on contacts are only ever created by platform users, so there's nothing to meter.That leaves this policy minting a
ResourceGrantper user for a resource type that no longer exists anywhere, growing with every new user.Blast radius
None. Nothing claims
user-notesnow that milo-os/milo#793 is closed, and a grant for a resource type with no claims is inert. The project-scoped notes grant (100 per project) is untouched and still doing real work.Contact notes keep working — milo-os/milo#792 is what fixed those, and it does so by not creating a claim at all, so it needs no grant.
Test plan
kustomize build config/services/notes.miloapis.comrenders only the project grant policyuser-notesin config