Skip to content

fix(ui): Stretch disabled rows in the delete dialog's related list - #444

Merged
mattdjenkinson merged 1 commit into
mainfrom
fix/delete-dialog-row-width
Oct 6, 2026
Merged

mattdjenkinson merged 1 commit into
mainfrom
fix/delete-dialog-row-width

Conversation

@mattdjenkinson

@mattdjenkinson mattdjenkinson commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

In the delete-workload dialog, rows you can't tick in "Also delete related resources" were narrower than the list. That covers ALBs that also route to other workloads, networks used by other workloads, and rows you lack permission to delete. Their "Load balancer" / "Network" label sat partway across the row, and the divider above each one stopped short.

Cause: these rows get a tooltip explaining why they're disabled. datum-ui's Tooltip wraps its trigger in a span.relative.inline-flex, so the row only grew as wide as its content. Rows you can tick have no tooltip, so they were fine.

Fix: wrap the tooltip in a flex flex-col div, which stretches the span to the list's width, and give the row min-w-0 flex-1 so it fills the span. min-w-0 keeps long hostnames truncating. All of these classes were already used in this file, so they're in the portal's CSS.

Screenshots

Before:
delete-dialog-before

After:
delete-dialog-after

Testing

  • Typecheck is clean.
  • I rendered the dialog in headless Chrome against cloud-portal's compiled CSS with the same three rows as the bug report: one ALB you can tick, one shared ALB and one shared network. I checked at desktop and narrow widths. Every row spans the list, the type labels line up on the right, and long hostnames still truncate.
  • I haven't checked it in the real portal yet.

datum-ui's Tooltip wraps its trigger in an inline-flex span, so rows
disabled with a tooltip (shared ALB/network, no permission) shrank to
their content: the type label sat mid-row and the divider stopped short.
Stretch the span with a column flex wrapper and the row with flex-1.
@mattdjenkinson
mattdjenkinson requested a review from a team as a code owner October 6, 2026 14:08
@mattdjenkinson
mattdjenkinson merged commit b1b73f3 into main Oct 6, 2026
11 checks passed
@mattdjenkinson
mattdjenkinson deleted the fix/delete-dialog-row-width branch October 6, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants