Repository navigation
fix(ui): Stretch disabled rows in the delete dialog's related list - #444
Merged
Merged
Conversation
datum-ui's Tooltip wraps its trigger in an inline-flex span, so rows disabled with a tooltip (shared ALB/network, no permission) shrank to their content: the type label sat mid-row and the divider stopped short. Stretch the span with a column flex wrapper and the row with flex-1.
ecv
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the delete-workload dialog, rows you can't tick in "Also delete related resources" were narrower than the list. That covers ALBs that also route to other workloads, networks used by other workloads, and rows you lack permission to delete. Their "Load balancer" / "Network" label sat partway across the row, and the divider above each one stopped short.
Cause: these rows get a tooltip explaining why they're disabled. datum-ui's
Tooltipwraps its trigger in aspan.relative.inline-flex, so the row only grew as wide as its content. Rows you can tick have no tooltip, so they were fine.Fix: wrap the tooltip in a
flex flex-coldiv, which stretches the span to the list's width, and give the rowmin-w-0 flex-1so it fills the span.min-w-0keeps long hostnames truncating. All of these classes were already used in this file, so they're in the portal's CSS.Screenshots
Before:

After:

Testing