Repository navigation
fix(controller): discover node-qualified attachment advertisements - #31
Merged
Merged
Conversation
privateip
approved these changes
Oct 9, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Galactic names attachment BGP advertisements with hex-encoded VPC and attachment identifiers followed by the node name. The VPC controller was treating those identity segments as base62, so it could not match current advertisements to
VPCAttachmentresources.Decode the identity segments from hex and index attachments with the same canonical key. Advertisement events can then project the node, host interface, subnet, and
Programmedcondition into attachment status without manual patches.Validation: Build, unit tests, end-to-end tests, lint, and publish checks pass in CI.
Related work:
ServiceEndpointandServiceRoutePolicyAPIs