Skip to content

Patch node-tar and other high dependency advisories - #86

Merged
ecv merged 3 commits into
mainfrom
fix/node-tar-advisory
Oct 7, 2026
Merged

ecv merged 3 commits into
mainfrom
fix/node-tar-advisory

Conversation

@ecv

@ecv ecv commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Backstage ships a version of the node-tar archive library that has a known denial-of-service flaw, flagged as a critical Dependabot alert.

The project pinned the library to an old release, so this moves the pin to the patched one.

This also clears the other open high Dependabot alerts, all 34 in total, by re-resolving the lockfile within the version ranges packages already declare.

No new overrides were added, no direct dependency changed major version, and one override that nothing used any more was removed.

Notes

The pending Backstage bump (#85) does not fix these on its own, because it keeps the old pin. It also conflicts with this PR on the lockfile, so whichever lands second re-locks.

Test plan

  • Dependencies install cleanly from the lockfile and no vulnerable node-tar remains
  • The type check, backend build and unit tests pass
  • The open high Dependabot alerts close after merge

Related to datum-cloud/infra#6681, datum-cloud/infra#6691

node-tar through 7.5.18 allows a denial of service (GHSA-23hp-3jrh-7fpw,
critical Dependabot alert on the lockfile). The repo pins tar to 7.5.16
through a resolutions entry, so every consumer was held on the vulnerable
release even though the parents already request ^7.5.21.

Key changes:
- bump the tar resolution from 7.5.16 to 7.5.22
- re-lock tar to 7.5.22, the only tar entry in the lockfile

Related to datum-cloud/infra#6681
@ecv ecv changed the title fix: Update node-tar to the patched release Patch the node-tar denial-of-service flaw Oct 3, 2026
@ecv
ecv marked this pull request as ready for review October 3, 2026 02:58
@ecv
ecv requested a review from privateip October 3, 2026 03:05
Re-resolve vulnerable transitive dependencies within the version ranges
their parents already declare, so the open high Dependabot alerts no
longer match anything in the lockfile. No new resolutions are added and
no direct dependency crosses a major version.

Key changes:
- Re-resolve brace-expansion, browserslist, fast-uri, immutable,
  ip-address, linkify-it, multer, postcss, shell-quote, svgo and
  js-yaml to patched releases
- Refresh the Module Federation packages, which pin adm-zip and undici
  exactly, to the release that carries the patched versions
- Refresh the AWS XML builder and swagger-ui-react, which pinned
  fast-xml-parser and js-yaml exactly
- Drop the undici override, which no longer matches any dependency
@ecv ecv changed the title Patch the node-tar denial-of-service flaw Patch node-tar and other high dependency advisories Oct 3, 2026
The broad axios range still resolved to 1.18.0 after the lockfile
refresh. Re-resolve it within range so both ranges share 1.20.0.

Key changes:
- Merge the two axios lock entries into one at 1.20.0
@ecv
ecv merged commit cfb6f48 into main Oct 7, 2026
6 of 7 checks passed
@ecv
ecv deleted the fix/node-tar-advisory branch October 7, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants