Repository navigation
fix: Validate the weekly Backstage bump - #84
Merged
Merged
Conversation
The weekly update opened a pull request that no check ever ran on, because GitHub gates workflow runs on a pull request the workflow token opens. Ten weekly bumps reached a reviewer with nothing tested, and the body asked that reviewer to rely on an end-to-end run that never started. The bump now validates its own branch. The scheduled run calls the same build, unit test and kind deployment workflows a pull request calls, and points them at the bump branch, so an upstream release that breaks either shows red in that run. Key changes: - Open the bump pull request as a draft and mark it ready only once the build, the unit tests and the kind deployment pass - Take an optional ref on the reusable build and deployment workflows so a caller can validate a branch other than its own - Rewrite the pull request body, which asked for a validation that could not happen A repository token would fix this the other way, by opening the pull request as an identity whose events start workflows. That needs a credential this repository does not hold, and the branch stays draft either way, so the checks move to where they can run today.
scotwells
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The weekly Backstage update opens a pull request that no check runs on, because GitHub does not start workflows for a pull request the workflow token opens.
Ten weekly bumps have reached a reviewer with nothing tested, and the most recent one carried two upstream minor releases.
The bump now validates its own branch. It opens the pull request as a draft, runs the same build, unit tests and kind deployment a pull request runs, and marks the pull request ready only when all three pass.
Test plan
Fixes #80