feat: centralize all constants in constants.ts#230
Closed
ritoban23 wants to merge 11 commits into
Closed
Conversation
* chore: add comments * chore: 🚨 lint fix
…atazip-inc#195) * feat: add error logs i check conenction for source and destination * fix: parse json message as string * chore: update response key * chore: refactor * chore: remove logEntry struct * fix: log parsing * fix: log parsing * fix: logs parsing logic * docs: updated api contract
…ogs-in-test-connection feat: show error logs in test connection
|
|
Contributor
|
hey thanks a lot for your contribution @ritoban23 can you also go ahead and share the pr on our slack in contribute-to-olake channel? |
Collaborator
|
Hi @ritoban23, please raise PR to the staging branch |
ritoban23
force-pushed
the
feat/centralize-constants
branch
from
57059e1 to
23df4d4
Compare
Author
|
@deepanshupal09-datazip should i close this and make a new pr? |
Collaborator
yes, please |
Author
|
closing to reopen with a pr to the staging branch |
deepanshupal09-datazip
added
hacktoberfest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR centralizes all scattered constants throughout the codebase into a single
constants.tsfile. Previously, constants like connector types, status values, tab types, and default values were hardcoded in multiple files.Key Changes:
ui/src/utils/constants.ts:STREAM_FILTERS- Filter options for job streamsCONNECTOR_TYPE_MAP- Mapping between lowercase and proper case connector namesDEFAULT_CONNECTORS- Default connector values for sources and destinationsTAB_TYPE_VALUES- Tab navigation constants with proper TypeScript literal typesSTATUS_VALUES- Status constants for entities and jobsBenefits:
Fixes #152
Type of change
How Has This Been Tested?
pnpm run buildcompletes successfullypnpm run lintpasses with 0 errors and 0 warningsTest Configuration:
Screenshots or Recordings
No visual changes - this is an internal refactoring that improves code organization and maintainability.
Related PR's (If Any):