Skip to content

fix(FE): using save icon instead of download icon #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarthak-kumar-shailendra wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

fix(FE): using save icon instead of download icon #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee9bb96
fix: using save icon instead of download icon
sarthak-kumar-shailendra Oct 5, 2025
eede39e
Merge branch 'staging' into SS/FixSaveIcon
Akshay-datazip Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ui/src/modules/jobs/pages/JobCreation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
import { useState, useRef } from "react"
import { useNavigate, Link, useLocation } from "react-router-dom"
import { message } from "antd"
import {
ArrowLeftIcon,
ArrowRightIcon,
DownloadSimpleIcon,
} from "@phosphor-icons/react"
import { ArrowLeft, ArrowRight, FloppyDiskIcon } from "@phosphor-icons/react"

Check failure on line 4 in ui/src/modules/jobs/pages/JobCreation.tsx

View workflow job for this annotation

GitHub Actions / Lint Code 

'ArrowRight' is defined but never used

Check failure on line 4 in ui/src/modules/jobs/pages/JobCreation.tsx

View workflow job for this annotation

GitHub Actions / Lint Code 

'ArrowLeft' is defined but never used
import { v4 as uuidv4 } from "uuid"

import { useAppStore } from "../../../store"
Expand Down Expand Up @@ -404,7 +400,7 @@
to="/jobs"
className="flex items-center gap-2 p-1.5 hover:rounded-md hover:bg-gray-100 hover:text-black"
>
<ArrowLeftIcon className="mr-1 size-5" />

Check failure on line 403 in ui/src/modules/jobs/pages/JobCreation.tsx

View workflow job for this annotation

GitHub Actions / Lint Code 

'ArrowLeftIcon' is not defined
</Link>

<div className="text-2xl font-bold"> Create Job</div>
Expand Down Expand Up @@ -533,7 +529,7 @@
onClick={handleSaveJob}
className="flex items-center justify-center gap-2 rounded-md border border-gray-400 px-4 py-1 font-light hover:bg-[#ebebeb]"
>
<DownloadSimpleIcon className="size-4" />
<FloppyDiskIcon className="size-4" />
Save Job
</button>
</div>
Expand All @@ -556,7 +552,7 @@
onClick={handleNext}
>
{currentStep === JOB_CREATION_STEPS.STREAMS ? "Create Job" : "Next"}
<ArrowRightIcon className="size-4 text-white" />

Check failure on line 555 in ui/src/modules/jobs/pages/JobCreation.tsx

View workflow job for this annotation

GitHub Actions / Lint Code 

'ArrowRightIcon' is not defined
</button>
<TestConnectionModal />
<TestConnectionSuccessModal />
Expand Down
Loading