docs: document CONNECTOR_DISCOVERY_ENABLED for Fusion-only / air-gapped deployments#150
Open
antoniocali wants to merge 1 commit into
Open
Conversation
Surface the new olake-ui config flag through the chart's values.yaml comments and README. No template change is needed since olakeUI.env is already a passthrough; this is purely a discoverability improvement so operators of Fusion-only / air-gapped deployments can find the knob. Companion to datazip-inc/olake-ui#382 and datazip-inc/olake-ui#380.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to datazip-inc/olake-ui#382, which adds a
CONNECTOR_DISCOVERY_ENABLEDserver flag (and a matchingDEFAULT_CONNECTOR_VERSION) to skip Docker Hub / ECR / GCR queries in Fusion-only and air-gapped deployments (datazip-inc/olake-ui#380).The chart needs no template change to support this —
olakeUI.envis already a passthrough map, so any env var set there is propagated to the UI pod. This PR is purely about discoverability: putting the new knob where operators will actually see it.Changes
helm/olake/values.yaml— add a commented example underolakeUI.envshowing how to disable discovery and pin a default version.helm/olake/README.md— add a "Disabling Connector Discovery (Fusion-only / Air-gapped)" subsection alongside the existing "Private Container Registry" section. Explains the use case (Fusion-only Iceberg maintenance, no CDC) and the registry-rate-limit motivation.Notes
olakego/ui:latest. Suggest merging this after, or after a new UI image is tagged.Test plan
helm lint helm/olake/cleanhelm template ... --set olakeUI.env.CONNECTOR_DISCOVERY_ENABLED=false --set olakeUI.env.DEFAULT_CONNECTOR_VERSION=v0.3.18and confirm both vars appear in the olake-ui Deployment env (they should, sinceolakeUI.envis already passed through via the existingrangeloop)