Conversation
The bundled postgres secret template (`templates/postgresql/secret.yaml`)
always emits `helm.sh/hook: pre-install,pre-upgrade` with
`hook-delete-policy: before-hook-creation`, regardless of the
`useStandardResources` flag. The sibling worker secret template
(`templates/olake-worker/secret.yaml`) gates the same annotations on
`{{- if not .Values.useStandardResources }}` — postgres was missed.
Effect for users running this chart under ArgoCD with the default
`useStandardResources: true`:
- ArgoCD interprets the secret as a PreSync hook.
- With `BeforeHookCreation` deletion policy, the resource is treated
as transient and never persists in the cluster.
- `postgresql-0` and the `temporal` init container both `envFrom` /
`valueFrom: secretKeyRef` against `<release>-postgresql-secret`
and end up stuck in `CreateContainerConfigError`:
`Error: secret "<release>-postgresql-secret" not found`.
Fix mirrors the worker-secret pattern exactly: wraps the three
`helm.sh/hook*` lines in `{{- if not .Values.useStandardResources }}`,
and adds the same `TODO: Remove the Helm hook logic in a future release`
comment. With this change:
- `useStandardResources: true` (default) — secret renders as a standard
resource, no hook annotations, persists.
- `useStandardResources: false` (legacy) — unchanged behavior, hook
annotations still emitted.
Verified with `helm template`:
default mode → `metadata.annotations` empty on the postgres secret
legacy mode → all three `helm.sh/hook*` annotations present, matching
the worker secret template
…standard-resources fix(postgresql): gate helm.sh/hook annotations on useStandardResources
Decrypt AES-256-GCM (local) and AWS KMS encrypted configs stored in the database before passing them to job execution. If OLAKE_SECRET_KEY is not set, configs are used as-is. Co-authored-by: vikash390 <vikash@datazip.io> Co-authored-by: Cursor <cursoragent@cursor.com>
vishalm0509
changed the title
vikaxsh
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release OLake worker version
v0.3.6Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):