-
Notifications
You must be signed in to change notification settings - Fork 7
feat: support for external temporal #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
52417b3
feat: support for external temporal
saptarshi-datazip 85c5514
fix: resolved comments
saptarshi-datazip 6ad1046
feat: add support for external temporal
schitizsharma 2793510
feat: separate cloud and true external temporal
schitizsharma 5c8e69e
fix: pr review fixes
schitizsharma e969310
chore: add if-clause for client creation
schitizsharma 6354cf6
chore: refactor code
vishalm0509 9bd8bb1
chore: add timeout in waitForAsyncOperation method
vishalm0509 b080c59
chore: init client once
vishalm0509 eb7436e
chore: supress gosec warning because handled internally by temporal
schitizsharma 8203a16
Merge branch 'feat/worker-external-temporal' of https://github.com/da…
schitizsharma 9eca032
Merge pull request #140 from datazip-inc/feat/worker-external-temporal
schitizsharma 53dbafe
Merge pull request #149 from datazip-inc/staging
vikaxsh 453ab3f
feat: set minVersion for TLS
schitizsharma f2359a0
Merge branch 'master' of https://github.com/datazip-inc/olake-helm in…
saptarshi-datazip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| {{- if and (not .Values.temporal.enabled) (not .Values.temporal.external.existingSecret) }} | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ include "olake.temporal.secretName" . }} | ||
| namespace: {{ include "olake.namespace" . }} | ||
| labels: | ||
| {{- include "olake.labels" . | nindent 4 }} | ||
| type: Opaque | ||
| stringData: | ||
| {{- with .Values.temporal.external.properties }} | ||
| {{ $.Values.temporal.external.secretKeys.TEMPORAL_ADDRESS | default "TEMPORAL_ADDRESS" }}: {{ .TEMPORAL_ADDRESS | quote }} | ||
| {{ $.Values.temporal.external.secretKeys.TEMPORAL_API_KEY | default "TEMPORAL_API_KEY" }}: {{ .TEMPORAL_API_KEY | quote }} | ||
| {{ $.Values.temporal.external.secretKeys.TEMPORAL_ENABLE_TLS | default "TEMPORAL_ENABLE_TLS" }}: {{ .TEMPORAL_ENABLE_TLS | quote }} | ||
| {{ $.Values.temporal.external.secretKeys.TEMPORAL_EXTERNAL | default "TEMPORAL_EXTERNAL" }}: {{ .TEMPORAL_EXTERNAL | quote }} | ||
| {{ $.Values.temporal.external.secretKeys.TEMPORAL_NAMESPACE | default "TEMPORAL_NAMESPACE" }}: {{ .TEMPORAL_NAMESPACE | quote }} | ||
| {{ $.Values.temporal.external.secretKeys.TEMPORAL_TASK_QUEUE | default "TEMPORAL_TASK_QUEUE" }}: {{ .TEMPORAL_TASK_QUEUE | quote }} | ||
| {{- end }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.