Open
Conversation
tatethurston
force-pushed
the
tatethurston/ruby-3-in-ci
branch
2 times, most recently
from
4034b30 to
0d4217e
Compare
tatethurston
force-pushed
the
tatethurston/ruby-3-in-ci
branch
2 times, most recently
from
15c622e to
d4f5c91
Compare
tatethurston
commented
May 2, 2024
| docile (~> 1.1.0) | ||
| json (~> 1.8) | ||
| set (1.1.0) | ||
| simplecov (0.17.1) |
Author
There was a problem hiding this comment.
bumped simplecov because the underlying json version for the previous version is not compatible with ruby 3.x
tatethurston
commented
May 2, 2024
| s.rdoc_options << '--title' << 'Datastax Ruby Driver' << '--main' << 'README.md' << '--line-numbers' | ||
|
|
||
| s.required_ruby_version = '>= 2.2.0' | ||
| s.required_ruby_version = '>= 2.3.0' |
Author
There was a problem hiding this comment.
sorted_set requires ruby 2.3. I've seen libraries not consider bumps in minimum ruby versions breaking changes when the dropped ruby version(s) is passed EOL so I'll defer here to the maintainers w.r.t versioning.
tatethurston
force-pushed
the
tatethurston/ruby-3-in-ci
branch
6 times, most recently
from
fc391c6 to
450fddc
Compare
tatethurston
force-pushed
the
tatethurston/ruby-3-in-ci
branch
from
450fddc to
e5fde7c
Compare
Author
|
Hey @absurdfarce all the specs here are passing but it looks like Do you want to update or drop testing this ruby version, or continue to ignore this failure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
sorted_setdependency so the gem can run under Ruby 3.x and updates the CI to test against Ruby 3.0 and 3.1.Fixes https://datastax-oss.atlassian.net/browse/RUBY-336.