Skip to content

FAL-1918 Update actions subpackage (checkout, cache and java-setup) v4 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
himanshudatastax wants to merge 6 commits into from
Closed

FAL-1918 Update actions subpackage (checkout, cache and java-setup) v4 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31e8bf2
FAL-1918 Update actions subpackages (checkout, cache and javasetup) v…
himanshudatastax May 27, 2026
2eb6a2a
FAL-1918 reverting java setup version
himanshudatastax May 27, 2026
df326b3
Comment out unnecessary calling of protected method, causing compile …
himanshudatastax Jun 10, 2026
dbb35fc
Reformating comments
himanshudatastax Jun 10, 2026
17c601f
removing un-necessary
himanshudatastax Jun 10, 2026
12c7fb8
Successfully executed ./gradlew :spotlessApply again
himanshudatastax Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Gradle cache
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: |
~/.gradle/caches
Expand Down
5 changes: 0 additions & 5 deletions ...va/com/datastax/fallout/components/metrics/MetricsCollectionConfigurationManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;

import com.datastax.fallout.ops.NodeGroup;
import com.datastax.fallout.util.ResourceUtils;

import static com.datastax.fallout.assertj.Assertions.assertThat;
Expand All @@ -38,7 +37,6 @@
import static com.github.tomakehurst.wiremock.client.WireMock.get;
import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.options;
import static org.mockito.Mockito.mock;

class MetricsCollectionConfigurationManagerTest
{
Expand Down Expand Up @@ -92,7 +90,6 @@ public void shouldGetMetricFromHttpEndpoint() throws IOException
{
MetricsCollectionConfigurationManager metricsCollectionConfigurationManager =
new MetricsCollectionConfigurationManager(instantSupplier);
metricsCollectionConfigurationManager.configureImpl(mock(NodeGroup.class));

String jsonResponse =
metricsCollectionConfigurationManager.executeGetRequestForJsonContent(metricName, prometheusUrl());
Expand All @@ -110,7 +107,6 @@ public void shouldThrowWhenGetNonExistingMetricFromHttpEndpoint() throws IOExcep
{
MetricsCollectionConfigurationManager metricsCollectionConfigurationManager =
new MetricsCollectionConfigurationManager(instantSupplier);
metricsCollectionConfigurationManager.configureImpl(mock(NodeGroup.class));

assertThatThrownBy(
() -> metricsCollectionConfigurationManager.executeGetRequestForJsonContent(nonExistingMetricName,
Expand All @@ -127,7 +123,6 @@ public void shouldCollectMetricsIntoArtifactsDirectoryFromPrometheusAPI()
Supplier<Instant> instantSupplier = nowReference::get;
MetricsCollectionConfigurationManager metricsCollectionConfigurationManager =
new MetricsCollectionConfigurationManager(instantSupplier);
metricsCollectionConfigurationManager.configureImpl(mock(NodeGroup.class));

String metricName = "metric_a";
Instant end = start.plus(Duration.ofSeconds(100));
Expand Down
Loading