Skip to content

314 fix t2l caching mechanism #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inakleinbottle merged 2 commits into from
Apr 13, 2026
Merged

314 fix t2l caching mechanism #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf9455
Fix incorrect dictionary lookup for t2l caching
inakleinbottle Apr 8, 2026
57b6a23
Add a test for caching behaviour
inakleinbottle Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roughpy/compute/_src/lie_basis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,7 @@ PyObject* get_t2l_matrix(PyObject* basis, PyObject* dtype_obj)
if (t2l == NULL) { return NULL; }

Py_INCREF(t2l);
PyDict_SetItem(self->l2t, (PyObject*) dtype, t2l);
PyDict_SetItem(self->t2l, (PyObject*) dtype, t2l);

return t2l;
}
Expand Down
26 changes: 20 additions & 6 deletions tests/compute/test_l2t_and_t2l.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@

from roughpy import compute as rpc

import pytest
import numpy as np
from numpy.testing import assert_array_equal, assert_array_almost_equal




def test_l2t_t2l_roundtrip():
lie_basis = rpc.LieBasis(4, 4)
tensor_basis = rpc.TensorBasis(lie_basis.width, lie_basis.depth)
Expand All @@ -25,7 +22,6 @@ def test_l2t_t2l_roundtrip():
assert_array_almost_equal(x.data, y.data, decimal=15)



def test_l2t_scaled_t2l_roundtrip():
lie_basis = rpc.LieBasis(4, 4)
tensor_basis = rpc.TensorBasis(lie_basis.width, lie_basis.depth)
Expand All @@ -40,7 +36,7 @@ def test_l2t_scaled_t2l_roundtrip():

y = rpc.tensor_to_lie(tensor_x, lie_basis)

assert_array_almost_equal(0.5*x.data, y.data, decimal=15)
assert_array_almost_equal(0.5 * x.data, y.data, decimal=15)


def test_l2t_t2l_scaled_roundtrip():
Expand All @@ -57,5 +53,23 @@ def test_l2t_t2l_scaled_roundtrip():

y = rpc.tensor_to_lie(tensor_x, lie_basis, scale_factor=0.5)

assert_array_almost_equal(0.5*x.data, y.data, decimal=15)
assert_array_almost_equal(0.5 * x.data, y.data, decimal=15)


def test_l2t_t2l_caching_consistency():
"""
Bug reported in #314

t2l was cached in l2t cache dict
"""

lie_basis = rpc.LieBasis(4, 4)

l2t_1 = lie_basis.get_l2t_matrix(np.dtype("float64"))
t2l_1 = lie_basis.get_t2l_matrix(np.dtype("float64"))

l2t_2 = lie_basis.get_l2t_matrix(np.dtype("float64"))
t2l_2 = lie_basis.get_t2l_matrix(np.dtype("float64"))

assert l2t_1 is l2t_2
assert t2l_1 is t2l_2
Loading