fix(glm): get family name from object (legacy dsBase) or from returned character#657
Open
ymarcon wants to merge 1 commit intodatashield:masterfrom
Open
fix(glm): get family name from object (legacy dsBase) or from returned character#657ymarcon wants to merge 1 commit intodatashield:masterfrom
ymarcon wants to merge 1 commit intodatashield:masterfrom
Conversation
StuartWheater
requested changes
Apr 8, 2026
Member
StuartWheater
left a comment
StuartWheater
left a comment
There was a problem hiding this comment.
The changes in the PR are needed but do not appear to be to the right branch.
I would expect to destination of the changes would be:
- v6.3.6-dev: next release if urgent, but could be merge in v6.4.0-dev. Bug fixes
- v6.4.0-dev: collections of changes for disparate activates, release could be months away
- v7.0.0-dev: big changes, current including performance improvements, and changes for v6.X
"master" is the last full release make, so not an appropriate destination for a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for datashield/dsBase#465 with backward compatibility.