[CFX-5121] Fix issue with unexpected update for 'dr start' on empty directory#392
Merged
victorborshak merged 3 commits intodatarobot-oss:mainfrom Mar 5, 2026
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
aremishevsky
approved these changes
Mar 5, 2026
Contributor
|
🔐 Smoke tests approved by maintainer ⏳ Running security scans before executing smoke tests with secrets... A maintainer has approved this fork PR to run smoke tests. Security scans will run first. |
cdevent
approved these changes
Mar 5, 2026
victorborshak
added
approved-for-smoke-tests
and removed
approved-for-smoke-tests
labels
Contributor
|
🔐 Smoke tests approved by maintainer ⏳ Running security scans before executing smoke tests with secrets... A maintainer has approved this fork PR to run smoke tests. Security scans will run first. |
Contributor
|
✅ All smoke tests passed! (Fork PR) ✅ Security Scan: success |
Contributor
|
✅ All smoke tests passed! (Fork PR) ✅ Security Scan: success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
Before
After
CHANGES
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: If you're an external contributor, the
run-smoke-testslabel won't work. Only maintainers can trigger smoke tests on forked PRs by applying theapproved-for-smoke-testslabel after security review. Please comment requesting maintainer review if you need smoke tests to run.Note
Low Risk
Low risk: small conditional change in
dr startversion-check flow plus new unit tests. Main risk is behavioral (fewer update prompts) if any repos rely on an emptyminimum-versionto force updates, which now won’t trigger.Overview
dr startno longer triggers a self-update prompt when the repository doesn’t specify aminimum-version(e.g., running in an empty/non-repo directory), by gating the check ontool.MinimumVersion != "".Adds
cmd/start/model_test.goto validate thatcheckSelfVersiondoes not request self-update in an empty directory, and that when aversions.yamlrequirement exists the code path executes without prompting for update indevbuilds.Written by Cursor Bugbot for commit 631a0d1. This will update automatically on new commits. Configure here.