Corrected logic for start template#391
Open
carsongee wants to merge 1 commit intodatarobot-oss:mainfrom
Open
Conversation
8f8c4ec to
8262e2b
Compare
c-h-russell-walker
approved these changes
Mar 3, 2026
Contributor
|
🔐 Smoke tests approved by maintainer ⏳ Running security scans before executing smoke tests with secrets... A maintainer has approved this fork PR to run smoke tests. Security scans will run first. |
Contributor
|
✅ All smoke tests passed! (Fork PR) ✅ Security Scan: success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
Added start by default, and instead gated the loop on finding sub-component start tasks
Note
Low Risk
Low risk template change that only affects generated
Taskfileoutput for thestarttask; behavior changes are limited to always exposingtask startwhile conditionally running component:startsubtasks when discovered.Overview
Always generates the top-level
starttask inTaskfile.tmpl.yamlinstead of omitting it when no component:starttasks are found.The component
{{ .StartComponents }}loop is now the only part gated by{{- if .HasStart }}, sotask startconsistently runs the base setup steps and only chains into component:starttasks when available.Written by Cursor Bugbot for commit 8262e2b. This will update automatically on new commits. Configure here.