Skip to content

Corrected logic for start template#391

Open
carsongee wants to merge 1 commit intodatarobot-oss:mainfrom
carsongee:carsongee/missing_case_of_start
Open

Corrected logic for start template#391
carsongee wants to merge 1 commit intodatarobot-oss:mainfrom
carsongee:carsongee/missing_case_of_start

Conversation

@carsongee
Copy link
Contributor

@carsongee carsongee commented Mar 3, 2026

RATIONALE

Added start by default, and instead gated the loop on finding sub-component start tasks


Note

Low Risk
Low risk template change that only affects generated Taskfile output for the start task; behavior changes are limited to always exposing task start while conditionally running component :start subtasks when discovered.

Overview
Always generates the top-level start task in Taskfile.tmpl.yaml instead of omitting it when no component :start tasks are found.

The component {{ .StartComponents }} loop is now the only part gated by {{- if .HasStart }}, so task start consistently runs the base setup steps and only chains into component :start tasks when available.

Written by Cursor Bugbot for commit 8262e2b. This will update automatically on new commits. Configure here.

@carsongee carsongee changed the title [YOLO] Corrected logic for start template Corrected logic for start template Mar 3, 2026
Copy link
Contributor

@c-h-russell-walker c-h-russell-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carsongee carsongee force-pushed the carsongee/missing_case_of_start branch from 8f8c4ec to 8262e2b Compare March 3, 2026 20:53
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🔐 Smoke tests approved by maintainer

⏳ Running security scans before executing smoke tests with secrets...

A maintainer has approved this fork PR to run smoke tests. Security scans will run first.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

All smoke tests passed! (Fork PR)

✅ Security Scan: success
✅ Linux: success
✅ Windows: success

View run details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants