Merged
Conversation
added 5 commits
October 23, 2025 12:56
…r into customer/TUL
…r into customer/TUL
…r into customer/TUL
There was a problem hiding this comment.
Pull request overview
Fixes a duplicate HTML id attribute issue where id="search-navbar-container" appeared multiple times on the page because the ds-search-navbar component is rendered in both the header and the navbar. The fix changes the id to a class, which is valid for multiple instances.
Changes:
- Changed
id="search-navbar-container"toclass="search-navbar-container"in the search navbar template to eliminate duplicate IDs - Updated all CSS selectors in the spec file from
#search-navbar-containerto.search-navbar-container - Removed the now-obsolete cypress exclusion comment that referenced this duplicate ID issue
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/search-navbar/search-navbar.component.html | Changed id to class on the container div to avoid duplicate IDs |
| src/app/search-navbar/search-navbar.component.spec.ts | Updated 4 CSS selectors from ID (#) to class (.) to match the template change |
| cypress/integration/header.spec.ts | Removed comment that excluded #search-navbar-container from a11y tests due to the now-fixed duplicate ID |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Found duplicate id in html:
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review