UFAL/Broken matomo tracking with custom dimensions#1237
Merged
milanmajchrak merged 2 commits intodtq-devfrom Mar 10, 2026
Merged
UFAL/Broken matomo tracking with custom dimensions#1237milanmajchrak merged 2 commits intodtq-devfrom
milanmajchrak merged 2 commits intodtq-devfrom
Conversation
…ties for Matomo custom dimensions
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in Matomo custom dimension tracking: when ViewTrackerComponent was replaced by ViewTrackerResolverService, the dc_identifier property (extracted from dc.identifier.uri metadata) was dropped from angulartics2 event properties. browser-init.service.ts checks properties.dc_identifier to call Matomo's setCustomDimension, so without it the custom dimension tracking silently broke. The fix extracts the dc.identifier.uri value from the resolved DSO and includes it as dc_identifier in the tracked event properties, matching the behavior of the original component.
Changes:
- Service fix: extract
dc.identifier.urifrom the resolved DSO and include it asdc_identifierin thepage_viewevent properties - New spec file covering the restored behavior across success, missing metadata, null DSO, and custom
dsoPathscenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts |
Extracts dc_identifier from the resolved DSO and passes it in the event properties |
src/app/statistics/angulartics/dspace/view-tracker-resolver.service.spec.ts |
New unit tests covering the dc_identifier behavior |
src/app/statistics/angulartics/dspace/view-tracker-resolver.service.spec.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
When
ViewTrackerComponentwas replaced byViewTrackerResolverService(route resolver), thedc_identifierproperty was dropped from angulartics2 event properties. This broke Matomo custom dimension tracking —browser-init.service.tschecksproperties.dc_identifierto callsetCustomDimension, but it was alwaysundefined.Fix
Extract
dc.identifier.urifrom the resolved DSO and include it asdc_identifierin the event properties, restoring the behavior of the original component.Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review